Re: [PATCH] scripts/get_maintainer.pl: fix .mailmap handling

[Florian Mickler <florian@mickler.org>]

On Mon, 20 Sep 2010 17:14:45 -0700
Joe Perches <joe@perches.com> wrote:

> On Tue, 2010-09-21 at 00:35 +0200, florian@mickler.org wrote:
> > From: florian@mickler.org <florian@mickler.org>
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> 
> []
> 
> > -	my ($name, $address) = parse_email($line);
> > -	$line = format_email($name, $address, $email_usename);
> > +	next if (/^\s*$/); #skip empty lines
> > +	#print "entry: \"$_\"\n";
> 
> Please do not add commented out debugging code.
> Add and use use some centralized debug(foo) call.

Hm. Yes that might be better in the long run. 

> 
> []
> 
> > +sub mailmap {
> > +    my (@addresses) = @_;
> > +
> > +    my @ret = ();
> 
> Suboptimal naming.  I try to use descriptive names.
> 
> cheers, Joe
> 

:-) 

Come on, Joe! It was "sub mailmap" before. @addresses was @list before
and @ret is the list that get's returned by the function. 

If you think a patch is ok, you actually may say so. 

Regards,
Flo