From: Andi Kleen <andi@firstfloor.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/5] ACPI, APEI, Fix error path for memory allocation
Date: Tue, 21 Sep 2010 14:45:52 +0200 [thread overview]
Message-ID: <20100921124552.GD18991@one.firstfloor.org> (raw)
In-Reply-To: <1284865235-29920-5-git-send-email-ying.huang@intel.com>
On Sun, Sep 19, 2010 at 11:00:34AM +0800, Huang Ying wrote:
> @@ -475,7 +479,13 @@ int apei_resources_request(struct apei_resources *resources,
> }
> }
>
> - apei_resources_merge(&apei_resources_all, resources);
> + rc = apei_resources_merge(&apei_resources_all, resources);
> + if (rc) {
> + pr_err(APEI_PFX
> +"Error in APEI internal resource management, there may be inconsistent "
> +"between APEI internal and system resource management.");
Please fix the English. This will wrap in the syslog without \ns no?
Kernel messges should be not wider than 80 characters.
> + rc = apei_resources_sub(&apei_resources_all, resources);
> + if (rc)
> + pr_err(APEI_PFX
> +"Error in APEI internal resource management, there may be inconsistent "
> +"between APEI internal and system resource management.");
Same.
Also instead of Error it would be better just say what is wrong and don't
try to analyze the problem.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-09-21 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 3:00 [PATCH 0/5] ACPI, APEI, BUG fixes for 2.6.36 Huang Ying
2010-09-19 3:00 ` [PATCH 1/5] ACPI, APEI, Fix APEI related table size checking Huang Ying
2010-09-21 12:39 ` Andi Kleen
2010-09-26 5:30 ` Huang Ying
2010-09-19 3:00 ` [PATCH 2/5] ACPI, APEI, Fix acpi_pre_map() return value Huang Ying
2010-09-21 12:47 ` Andi Kleen
2010-09-19 3:00 ` [PATCH 3/5] ACPI, APEI, HEST Fix the unsuitable usage of platform_data Huang Ying
2010-09-21 12:43 ` Andi Kleen
2010-09-22 1:05 ` Jin Dongming
2010-09-23 9:06 ` huang ying
2010-09-19 3:00 ` [PATCH 4/5] ACPI, APEI, Fix error path for memory allocation Huang Ying
2010-09-21 12:45 ` Andi Kleen [this message]
2010-09-23 8:53 ` huang ying
2010-09-19 3:00 ` [PATCH 5/5] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation Huang Ying
2010-09-21 12:47 ` Andi Kleen
2010-09-23 9:04 ` huang ying
2010-09-27 5:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921124552.GD18991@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox