From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Olsa <jolsa@redhat.com>
Cc: robert.richter@amd.com, linux-kernel@vger.kernel.org,
oprofile-list@lists.sourceforge.net, tdm.rhbz@gmail.com
Subject: Re: [PATCH] oprofile: Add Support for Intel CPU Family 6 / Model 29
Date: Tue, 21 Sep 2010 13:21:05 +0200 [thread overview]
Message-ID: <201009211321.06172.arnd@arndb.de> (raw)
In-Reply-To: <1285053995-3811-1-git-send-email-jolsa@redhat.com>
On Tuesday 21 September 2010, Jiri Olsa wrote:
> --- a/arch/x86/oprofile/nmi_int.c
> +++ b/arch/x86/oprofile/nmi_int.c
> @@ -674,6 +674,7 @@ static int __init ppro_init(char **cpu_type)
> case 0x0f:
> case 0x16:
> case 0x17:
> + case 0x1d:
> *cpu_type = "i386/core_2";
> break;
> case 0x1a:
Just curious about the other missing IDs: this now supports all Core
microarchitecture CPUs, but only some Nehalem/Westmere ones.
There is support for 0x1a (Bloomfield/Gainestown) and 0x2e (Beckton), but
not for the much more common 0x1e (Lynnfield/Clarksfield/Jasper Forest),
0x25 (Clarkdale/Arrandale) and 0x26 (Gulftown/Westmere-EP).
Shouldn't those be added as well?
When you're there, it probably also wouldn't hurt to fill in the blanks
of some of the older CPUs like Tolopai (0x15) and newer Atoms (0x1c).
Arnd
next prev parent reply other threads:[~2010-09-21 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 7:26 [PATCH] oprofile: Add Support for Intel CPU Family 6 / Model 29 Jiri Olsa
2010-09-21 8:20 ` Robert Richter
2010-09-21 10:09 ` Andi Kleen
2010-09-21 10:33 ` Robert Richter
2010-09-27 7:39 ` [GIT PULL] oprofile fixes Robert Richter
2010-09-27 7:50 ` Ingo Molnar
2010-09-21 11:21 ` Arnd Bergmann [this message]
2010-09-21 14:13 ` [PATCH] oprofile: Add Support for Intel CPU Family 6 / Model 29 Robert Richter
2010-09-21 14:38 ` Andi Kleen
2010-09-22 7:26 ` Robert Richter
2010-09-22 8:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009211321.06172.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=robert.richter@amd.com \
--cc=tdm.rhbz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox