From: Jason Baron <jbaron@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
mathieu.desnoyers@polymtl.ca, hpa@zytor.com, tglx@linutronix.de,
rostedt@goodmis.org, roland@redhat.com, rth@redhat.com,
mhiramat@redhat.com, fweisbec@gmail.com, avi@redhat.com,
davem@davemloft.net, vgoyal@redhat.com, sam@ravnborg.org,
tony@bakeyournoodle.com
Subject: Re: [PATCH 03/10] jump label v11: base patch
Date: Tue, 21 Sep 2010 11:04:26 -0400 [thread overview]
Message-ID: <20100921150426.GB2873@redhat.com> (raw)
In-Reply-To: <0e1f6b339e72a449fed0df7b801da607.squirrel@www.firstfloor.org>
On Tue, Sep 21, 2010 at 04:41:19PM +0200, Andi Kleen wrote:
> > So there are ~150 tracepoints, but this code is also being proposed for
> > use with 'dynamic debug' of which there are > 1000, and I'm hoping for
> > more users moving forward.
>
> Even 1000 is fine to walk, but if it was sorted a binary search
> would be much faster anyways. That is then you would still
> need to search for each module, but that is a relatively small
> number (< 100)
>
yes, but then for each module, I need to again search through the table
to find the correct entires. Although there wouldn't be a 150
tracepoints to search for in each module there are a number of
tracepoints that are used by most modules, such as kmalloc, kfree...plus
any other users of this infrastructure.
> > Also, I think the hash table deals nicely with modules.
>
> Maybe but it's also a lot of code. And it seems to me
> that it is optimizing the wrong thing. Simpler is nicer.
>
> -Andi
>
its right to realize that the enable/disable paths are not at the heart
of this optimization. in fact, the initial few postings of this
patchset, didn't include the hash table, but the added support for
modules lead me to the current design.
thanks,
-Jason
next prev parent reply other threads:[~2010-09-21 15:05 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 15:08 [PATCH 00/10] jump label v11 Jason Baron
2010-09-17 15:08 ` [PATCH 01/10] jump label v11: make dynamic no-op selection available outside of ftrace Jason Baron
2010-09-17 15:28 ` Steven Rostedt
2010-09-24 8:58 ` [tip:perf/core] jump label: Make " tip-bot for Jason Baron
2010-09-17 15:08 ` [PATCH 02/10] jump label v11: make text_poke_early() globally visisble Jason Baron
2010-09-24 8:58 ` [tip:perf/core] jump label: Make text_poke_early() globally visible tip-bot for Jason Baron
2010-09-17 15:09 ` [PATCH 03/10] jump label v11: base patch Jason Baron
2010-09-17 18:21 ` David Miller
2010-09-21 2:37 ` Steven Rostedt
2010-09-21 13:12 ` Andi Kleen
2010-09-21 14:35 ` Jason Baron
2010-09-21 14:41 ` Andi Kleen
2010-09-21 15:04 ` Jason Baron [this message]
2010-09-21 15:09 ` Ingo Molnar
2010-09-21 15:14 ` Steven Rostedt
2010-09-21 17:35 ` H. Peter Anvin
2010-09-21 17:42 ` Andi Kleen
2010-09-21 17:36 ` Andi Kleen
2010-09-21 18:05 ` Steven Rostedt
2010-09-21 18:24 ` Mathieu Desnoyers
2010-09-21 19:48 ` Andi Kleen
2010-09-21 18:48 ` Andi Kleen
2010-09-21 17:39 ` Andi Kleen
2010-09-21 18:29 ` Konrad Rzeszutek Wilk
2010-09-21 18:55 ` Konrad Rzeszutek Wilk
2010-09-21 18:58 ` H. Peter Anvin
2010-09-24 8:59 ` [tip:perf/core] jump label: Base patch for jump label tip-bot for Jason Baron
2010-09-17 15:09 ` [PATCH 04/10] jump label v11: initialize workqueue tracepoints *before* they are registered Jason Baron
2010-09-24 8:59 ` [tip:perf/core] jump label: Initialize " tip-bot for Jason Baron
2010-09-17 15:09 ` [PATCH 05/10] jump label v11: jump_label_text_reserved() to reserve our jump points Jason Baron
2010-09-24 9:00 ` [tip:perf/core] jump label: Add jump_label_text_reserved() to reserve " tip-bot for Jason Baron
2010-09-17 15:09 ` [PATCH 06/10] jump label v11: tracepoint support Jason Baron
2010-09-24 9:00 ` [tip:perf/core] jump label: Tracepoint support for jump labels tip-bot for Jason Baron
2010-09-17 15:09 ` [PATCH 07/10] jump label v11: convert dynamic debug to use " Jason Baron
2010-09-24 9:00 ` [tip:perf/core] jump label: Convert " tip-bot for Jason Baron
2010-09-17 15:09 ` [PATCH 08/10] jump label v11: x86 support Jason Baron
2010-09-21 2:32 ` Steven Rostedt
2010-09-21 2:43 ` H. Peter Anvin
2010-09-21 15:25 ` Jason Baron
2010-09-21 15:29 ` Ingo Molnar
2010-09-21 15:35 ` Steven Rostedt
2010-09-21 16:33 ` Jason Baron
2010-09-21 18:30 ` Konrad Rzeszutek Wilk
2010-09-24 9:01 ` [tip:perf/core] jump label: " tip-bot for Jason Baron
2010-09-24 16:19 ` H. Peter Anvin
2010-09-24 16:34 ` Jason Baron
2010-09-24 17:30 ` H. Peter Anvin
2010-09-24 18:08 ` Steven Rostedt
2010-10-18 11:17 ` Peter Zijlstra
2010-10-18 12:48 ` Mathieu Desnoyers
2010-09-17 15:09 ` [PATCH 09/10] jump label 11: add sparc64 support Jason Baron
2010-09-20 22:25 ` Steven Rostedt
2010-09-20 22:30 ` David Miller
2010-09-20 22:38 ` Steven Rostedt
2010-09-21 15:37 ` Steven Rostedt
2010-09-21 16:27 ` David Miller
2010-09-23 3:09 ` Steven Rostedt
2010-09-24 9:01 ` [tip:perf/core] jump label: Add " tip-bot for David S. Miller
2010-09-17 15:09 ` [PATCH 10/10] jump label v11: add docs Jason Baron
2010-09-17 16:05 ` Mathieu Desnoyers
2010-09-20 22:28 ` Steven Rostedt
2010-09-21 16:20 ` Jason Baron
2010-09-21 8:20 ` matt mooney
2010-09-21 18:39 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921150426.GB2873@redhat.com \
--to=jbaron@redhat.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rth@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=tony@bakeyournoodle.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox