Re: [RFC 0/5] tty: move stuff around

Arnd Bergmann
2010-08-30T11:37:35Z

On Monday 30 August 2010, Alan Cox wrote:
> > Of course, moving stuff around always has the tendency to
> > break patches against it, so we might not want to do this after
> > all.
> >
> > Any other opinions?
>
> Linus actually suggested this should get done in some form a while ago
> back when I was tty maintainer but about the same time as I decided not
> to be.

ok.

> > tty: move tty layer code to drivers/tty
>
> I would be tempted to put the core stuff in /tty as its not drivers

Do you consider vt to be core (I guess yes)? What about hvc (I guess no)?

> > tty/vt: move files to drivers/tty/vt/
> > tty/hvc: move files to drivers/tty/hvc
> > tty/hw: move hardware drivers to drivers/tty/hw
> > tty: rearrange Kconfig structure
>
> drivers/serial should also walk into tty I think ?

Yes, good point.

> drivers/pcmcia/serial is a bit trickier but I guess should stay as with
> drivers/usb/serial

I don't see drivers/pcmcia/serial. Are you thinking of the tty drivers
in drivers/char/pcmcia? I moved both of these to drivers/tty/hw
in my patch.

> There are several unbuildable ancient drivers. Perhaps if we are having
> the great rename those should simply get deleted first, as there is no
> way to test them in their current config ?

These are the drivers I was planning to move:
+obj-$(CONFIG_MVME147_SCC) += generic_serial.o vme_scc.o
+obj-$(CONFIG_MVME162_SCC) += generic_serial.o vme_scc.o
+obj-$(CONFIG_BVME6000_SCC) += generic_serial.o vme_scc.o
+obj-$(CONFIG_ROCKETPORT) += rocket.o
+obj-$(CONFIG_SERIAL167) += serial167.o
+obj-$(CONFIG_CYCLADES) += cyclades.o
+obj-$(CONFIG_STALLION) += stallion.o
+obj-$(CONFIG_ISTALLION) += istallion.o
+obj-$(CONFIG_NOZOMI) += nozomi.o
+obj-$(CONFIG_DIGIEPCA) += epca/
+obj-$(CONFIG_SPECIALIX) += specialix.o
+obj-$(CONFIG_MOXA_INTELLIO) += moxa.o
+obj-$(CONFIG_A2232) += ser_a2232.o generic_serial.o
+obj-$(CONFIG_ATARI_DSP56K) += dsp56k.o
+obj-$(CONFIG_MOXA_SMARTIO) += mxser.o
+obj-$(CONFIG_COMPUTONE) += ip2/
+obj-$(CONFIG_RISCOM8) += riscom8.o
+obj-$(CONFIG_ISI) += isicom.o
+obj-$(CONFIG_SYNCLINK) += synclink.o
+obj-$(CONFIG_SYNCLINKMP) += synclinkmp.o
+obj-$(CONFIG_SYNCLINK_GT) += synclink_gt.o
+obj-$(CONFIG_SYNCLINK_CS) += synclink_cs.o
+obj-$(CONFIG_AMIGA_BUILTIN_SERIAL) += amiserial.o
+obj-$(CONFIG_BFIN_JTAG_COMM) += bfin_jtag_comm.o
+obj-$(CONFIG_SX) += sx.o generic_serial.o
+obj-$(CONFIG_RIO) += rio/ generic_serial.o
+obj-$(CONFIG_IPWIRELESS) += ipwireless/

Which of these do you think should get deleted?

AFAICT, the only ones that are getting nontrivial updates once in
a while are amiserial, bfin_jtag_comm, isicom, cyclades. moxa, mxser,
nozomi, serial167, stallion and synclink, while the users of
generic_serial.o seem to be the ones getting the least attention.

Arnd