Re: [PATCH 1/2] TTY: create /tty and move the tty core files there

Arnd Bergmann
2010-09-22T09:14:17Z

On Wednesday 22 September 2010, Greg KH wrote:
> The tty code should be at the root of the tree, as everyone
> needs it, and it's always built, and it's not really a "driver"
>
> Based on work done by Arnd Bergmann <arnd@arndb.de>
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> Makefile | 2 +-
> drivers/char/Makefile | 4 +---
> tty/Makefile | 8 ++++++++
> {drivers/char => tty}/n_tty.c | 0
> {drivers/char => tty}/tty_audit.c | 0
> {drivers/char => tty}/tty_buffer.c | 0
> {drivers/char => tty}/tty_io.c | 0
> {drivers/char => tty}/tty_ioctl.c | 0
> {drivers/char => tty}/tty_ldisc.c | 0
> {drivers/char => tty}/tty_mutex.c | 0
> {drivers/char => tty}/tty_port.c | 0

My original patch also moved pty.o, sysrq.o and the n_*.o line disciplines.
It's probably debatable where the line disciplines should go (I don't care
much, so don't ask me), but pty and sysrq seem like they should really
be part of the tty core directory.

Arnd