Re: [PATCH 2/2] TTY: create tty/vt and move the vt code there

Arnd Bergmann
2010-09-22T09:10:59Z

On Wednesday 22 September 2010, Greg KH wrote:
> diff --git a/drivers/char/Makefile b/drivers/char/Makefile
> index c999eac..acd1710 100644
> --- a/drivers/char/Makefile
> +++ b/drivers/char/Makefile
> @@ -12,10 +12,8 @@ obj-y += mem.o random.o
> obj-$(CONFIG_LEGACY_PTYS) += pty.o
> obj-$(CONFIG_UNIX98_PTYS) += pty.o
> obj-y += misc.o
> -obj-$(CONFIG_VT) += vt_ioctl.o vc_screen.o selection.o keyboard.o
> obj-$(CONFIG_BFIN_JTAG_COMM) += bfin_jtag_comm.o
> obj-$(CONFIG_CONSOLE_TRANSLATIONS) += consolemap.o consolemap_deftbl.o
> -obj-$(CONFIG_HW_CONSOLE) += vt.o defkeymap.o
> obj-$(CONFIG_MAGIC_SYSRQ) += sysrq.o
> obj-$(CONFIG_MVME147_SCC) += generic_serial.o vme_scc.o
> obj-$(CONFIG_MVME162_SCC) += generic_serial.o vme_scc.o
> @@ -114,7 +112,7 @@ obj-$(CONFIG_JS_RTC) += js-rtc.o
> js-rtc-y = rtc.o
>
> # Files generated that shall be removed upon make clean
> -clean-files := consolemap_deftbl.c defkeymap.c
> +clean-files := consolemap_deftbl.c

IMHO the CONFIG_CONSOLE_TRANSLATIONS stuff belongs in the same directory
as the VT driver, because it is only used in VT. It also puts all teh
unusual Makefile bits into one place.

Arnd