From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Balaji Rao <balajirrao@openmoko.org>,
Paul Fertser <fercerpav@gmail.com>
Subject: Re: [PATCH] drivers/power: add missing sysfs_remove_group() in pcf50633_mbc_remove()
Date: Wed, 22 Sep 2010 16:18:45 +0400 [thread overview]
Message-ID: <20100922121658.GA24829@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1285058157.26315.1.camel@mola>
On Tue, Sep 21, 2010 at 04:35:57PM +0800, Axel Lin wrote:
> sysfs entries should be removed when unload the module.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks!
> ---
> drivers/power/pcf50633-charger.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/power/pcf50633-charger.c b/drivers/power/pcf50633-charger.c
> index 066f994..4fa52e1 100644
> --- a/drivers/power/pcf50633-charger.c
> +++ b/drivers/power/pcf50633-charger.c
> @@ -456,6 +456,7 @@ static int __devexit pcf50633_mbc_remove(struct platform_device *pdev)
> for (i = 0; i < ARRAY_SIZE(mbc_irq_handlers); i++)
> pcf50633_free_irq(mbc->pcf, mbc_irq_handlers[i]);
>
> + sysfs_remove_group(&pdev->dev.kobj, &mbc_attr_group);
> power_supply_unregister(&mbc->usb);
> power_supply_unregister(&mbc->adapter);
> power_supply_unregister(&mbc->ac);
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-09-22 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 8:35 [PATCH] drivers/power: add missing sysfs_remove_group() in pcf50633_mbc_remove() Axel Lin
2010-09-22 12:18 ` Anton Vorontsov [this message]
2010-09-23 22:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922121658.GA24829@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=axel.lin@gmail.com \
--cc=balajirrao@openmoko.org \
--cc=fercerpav@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox