From: Andi Kleen <andi@firstfloor.org>
To: John Kacur <jkacur@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf build fixes for opensuse 10.0
Date: Wed, 22 Sep 2010 15:25:09 +0200 [thread overview]
Message-ID: <20100922132509.GD5766@basil.fritz.box> (raw)
In-Reply-To: <AANLkTimqTva4gYncxzeMokT19rYqZ4kj5p=jONYXmP7Q@mail.gmail.com>
On Wed, Sep 22, 2010 at 03:10:04PM +0200, John Kacur wrote:
> On Wed, Sep 22, 2010 at 1:15 PM, Andi Kleen <andi@firstfloor.org> wrote:
> >> On Wed, Sep 22, 2010 at 11:03 AM, Andi Kleen <andi@firstfloor.org> wrote:
> >>> Fix the perf Makefile to compile on opensuse 10.0
> >>>
> >>> -Werror in shipping code is usually a bad idea. Remove that.
> >>
> >> Why not remove it then when you ship the code, but leave it in the kernel
> >> where it is useful?
> >
> > What do you mean with "you ship"?
>
> The subject of your email is "perf build fixes for opensuse 10.0"
> So, I inferred from there.
You inferred wrong. That was just using it on opensuse 10.0
(opensuse 10.0 has already shipped a very long time ago, it's really
old by now)
>
> > I downloaded a kernel from kernel.org, it shipped to me and didn't
> > build.
>
> Any reason you can't fix the build errors instead?
That's what I did -- and then sent the patch.
> Btw, I just tried building the lastest perf in tip/master
> and I had no problems.
Because you're not using opensuse 10.0
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-09-22 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 9:03 [PATCH] perf build fixes for opensuse 10.0 Andi Kleen
2010-09-22 10:48 ` John Kacur
2010-09-22 11:15 ` Andi Kleen
2010-09-22 13:10 ` John Kacur
2010-09-22 13:25 ` Andi Kleen [this message]
2010-09-22 18:20 ` Ingo Molnar
2010-09-22 18:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922132509.GD5766@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox