From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755071Ab0IVPHr (ORCPT ); Wed, 22 Sep 2010 11:07:47 -0400 Received: from tomts36.bellnexxia.net ([209.226.175.93]:57269 "EHLO tomts36-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754636Ab0IVPHp (ORCPT ); Wed, 22 Sep 2010 11:07:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAL63mUxGGN6i/2dsb2JhbACiLnLEGIVBBI8w Date: Wed, 22 Sep 2010 11:07:43 -0400 From: Mathieu Desnoyers To: Andi Kleen Cc: jbaron@redhat.com, rusty@rustcorp.co.au, rostedt@goodmis.com, linux-kernel@vger.kernel.org, mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de, roland@redhat.com, rth@redhat.com, mhiramat@redhat.com, fweisbec@gmail.com, avi@redhat.com, davem@davemloft.net, vgoyal@redhat.com, sam@ravnborg.org, tony@bakeyournoodle.com, Andi Kleen Subject: Re: [PATCH 2/2] Rewrite jump_label.c to use binary search Message-ID: <20100922150743.GA6272@Krystal> References: <1285150102-5506-1-git-send-email-andi@firstfloor.org> <1285150102-5506-2-git-send-email-andi@firstfloor.org> <20100922113114.GA14179@Krystal> <4a8f3ad8416ed61cba1746883da1f839.squirrel@www.firstfloor.org> <589c3dd38437c80704d8224523efbccc.squirrel@www.firstfloor.org> <20100922150250.GB4897@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20100922150250.GB4897@Krystal> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.27.31-grsec (i686) X-Uptime: 11:06:26 up 168 days, 57 min, 2 users, load average: 0.20, 0.20, 0.13 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mathieu Desnoyers (mathieu.desnoyers@polymtl.ca) wrote: > * Andi Kleen (andi@firstfloor.org) wrote: > > > > > > > >>> + for (; entry < stop && entry->key == key; entry++) > > >>> + if (kernel_text_address(entry->code)) > > >> > > >> This does not work for modules I'm afraid, only for the core kernel. You > > >> should test for __module_text_address() somewhere. > > > > > > I thought it was shared now, but ok. > > > > Double checked. This is ok because kernel_text_address() > > already checks for modules. You were probably thinking > > of __kernel_text_address() > > Ah right, > > Although we have another problem: > > __module_text_address() includes module init text, which defeats the > purpose of the check put in there by Jason. > > So the check works for the core kernel, but not for modules. So, we have this issue, but I also have a question for Jason: what happens if someone puts static jump in a function declared in the __init section of the core kernel/module ? Can we enable them at early boot ? Thanks, Mathieu > > Mathieu > > > > > -Andi > > > > -- > Mathieu Desnoyers > Operating System Efficiency R&D Consultant > EfficiOS Inc. > http://www.efficios.com -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com