From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ds2760_battery: add HAS_IOMEM dependency
Date: Thu, 23 Sep 2010 14:57:27 +0400 [thread overview]
Message-ID: <20100923105727.GA22890@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100923124445.5309c100@mschwide.boeblingen.de.ibm.com>
On Thu, Sep 23, 2010 at 12:44:45PM +0200, Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Fix this Kconfig warning on allmodconfig for s390:
>
> warning: (BATTERY_DS2760 && POWER_SUPPLY) selects W1 which has unmet direct dependencies (HAS_IOMEM)
>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> ---
>
> drivers/power/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -urpN linux-2.6/drivers/power/Kconfig linux-2.6-patched/drivers/power/Kconfig
> --- linux-2.6/drivers/power/Kconfig 2010-09-23 08:47:36.000000000 +0200
> +++ linux-2.6-patched/drivers/power/Kconfig 2010-09-23 08:47:39.000000000 +0200
> @@ -64,6 +64,7 @@ config TEST_POWER
>
> config BATTERY_DS2760
> tristate "DS2760 battery driver (HP iPAQ & others)"
> + depends on HAS_IOMEM
> select W1
> select W1_SLAVE_DS2760
I think the better fix would be to turn this into 'depends on W1',
and remove these selects.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-09-23 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 10:44 [PATCH] ds2760_battery: add HAS_IOMEM dependency Martin Schwidefsky
2010-09-23 10:57 ` Anton Vorontsov [this message]
2010-09-23 13:21 ` Martin Schwidefsky
2010-09-23 13:38 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923105727.GA22890@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox