From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jesse Marroquin <Jesse.Marroquin@maxim-ic.com>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver
Date: Thu, 23 Sep 2010 13:04:43 +0100 [thread overview]
Message-ID: <20100923120443.GF25663@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40D469C1248@ITSVLEX06.it.maxim-ic.internal>
On Wed, Sep 22, 2010 at 07:58:48PM -0700, Peter Hsiang wrote:
> This patch adds the MAX98088 CODEC driver.
> Signed-off-by: Peter Hsiang <peter.hsiang@maxim-ic.com>
When you submitted the driver on the 31st of August my first comment in
the review was:
| The major issue with this is that the driver needs to be updated to
| current ASoC versions - you should always be working against the trees
| that are in linux-next for new drivers. For ASoC you should be looking
| at:
| git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
Currently you should be looking at for-next or for-2.6.37, though the
branch names will change as kernel development moves forward.
This must be rectified before the driver can be considered for inclusion
in the kernel. As things stand the code will not compile.
next prev parent reply other threads:[~2010-09-23 12:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 2:58 [PATCH] ASoC: Add max98088 CODEC driver Peter Hsiang
2010-09-23 12:04 ` Mark Brown [this message]
2010-09-23 17:56 ` Peter Hsiang
2010-09-23 18:38 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-09-29 2:34 Peter Hsiang
2010-09-29 3:37 ` Mark Brown
2010-09-29 21:42 ` Peter Hsiang
2010-09-29 22:18 ` Mark Brown
2010-09-30 0:52 ` Peter Hsiang
2010-09-30 0:58 ` Mark Brown
2010-09-30 1:20 ` Peter Hsiang
2010-10-13 1:20 ` Peter Hsiang
2010-10-13 1:47 ` Joe Perches
2010-10-13 8:24 ` Mark Brown
2010-10-13 10:32 ` Mark Brown
2010-10-14 3:18 ` Peter Hsiang
2010-10-14 3:30 ` Peter Hsiang
2010-10-15 10:04 ` Liam Girdwood
2010-10-15 10:55 ` Mark Brown
2010-10-15 17:23 ` Peter Hsiang
2010-08-31 21:08 Peter Hsiang
2010-09-01 11:14 ` Mark Brown
2010-09-02 23:30 ` Peter Hsiang
2010-09-03 10:17 ` Mark Brown
2010-09-22 2:49 ` Peter Hsiang
2010-09-22 10:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923120443.GF25663@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Jesse.Marroquin@maxim-ic.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox