From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754964Ab0IWMEq (ORCPT ); Thu, 23 Sep 2010 08:04:46 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:50808 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752579Ab0IWMEp (ORCPT ); Thu, 23 Sep 2010 08:04:45 -0400 Date: Thu, 23 Sep 2010 13:04:43 +0100 From: Mark Brown To: Peter Hsiang Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Peter Ujfalusi , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Jesse Marroquin Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver Message-ID: <20100923120443.GF25663@rakim.wolfsonmicro.main> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: BOFH excuse User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 22, 2010 at 07:58:48PM -0700, Peter Hsiang wrote: > This patch adds the MAX98088 CODEC driver. > Signed-off-by: Peter Hsiang When you submitted the driver on the 31st of August my first comment in the review was: | The major issue with this is that the driver needs to be updated to | current ASoC versions - you should always be working against the trees | that are in linux-next for new drivers. For ASoC you should be looking | at: | git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git Currently you should be looking at for-next or for-2.6.37, though the branch names will change as kernel development moves forward. This must be rectified before the driver can be considered for inclusion in the kernel. As things stand the code will not compile.