public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederik Deweerdt <frederik.deweerdt@xprog.eu>
To: acme@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [patch 36-rc5] perf browser ui segfault on 'a' for annotate
Date: Thu, 23 Sep 2010 22:19:01 +0200	[thread overview]
Message-ID: <20100923201901.GE31726@gambetta> (raw)

Hi Arnaldo,

There a typo in util/ui/browsers/hists.c that leads to a segfault when
you press the 'a' key on a non-resolved symbol (plain hex address).

This is fixed by the patch below.

Thanks,
Frederik

Signed-off-by: Frederik Deweerdt <frederik.deweerdt@xprog.eu>

diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c
index dafdf67..6866aa4 100644
--- a/tools/perf/util/ui/browsers/hists.c
+++ b/tools/perf/util/ui/browsers/hists.c
@@ -773,7 +773,7 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name)
 
 			switch (key) {
 			case 'a':
-				if (browser->selection->map == NULL &&
+				if (browser->selection->map == NULL ||
 				    browser->selection->map->dso->annotate_warned)
 					continue;
 				goto do_annotate;

             reply	other threads:[~2010-09-23 20:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23 20:19 Frederik Deweerdt [this message]
2010-10-04 17:56 ` [patch 36-rc5] perf browser ui segfault on 'a' for annotate Arnaldo Carvalho de Melo
2010-10-05 12:13 ` [tip:perf/core] perf ui hist browser: Fix " tip-bot for Frederik Deweerdt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100923201901.GE31726@gambetta \
    --to=frederik.deweerdt@xprog.eu \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox