From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Brian Bloniarz <phunge0@hotmail.com>,
Charles Butterfield <charles.butterfield@nextcentury.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Becker <chemobejk@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v2 1/4] resources: ensure alignment callback doesn't allocate below available start
Date: Fri, 24 Sep 2010 10:07:33 -0700 [thread overview]
Message-ID: <20100924100733.2e7fa2ac@jbarnes-desktop> (raw)
In-Reply-To: <20100917223212.24687.3519.stgit@bob.kio>
On Fri, 17 Sep 2010 16:32:12 -0600
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> The alignment callback returns a proposed location, which may have been
> adjusted to avoid ISA aliases or for other architecture-specific reasons.
> We already had a check ("tmp.start < tmp.end") to make sure the callback
> doesn't return a location above the available area.
>
> This patch adds a check to make sure the callback doesn't return something
> *below* the available area, as may happen if the callback tries to allocate
> top-down.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
Applied this series. It's way bigger than I'd like at this point, but
it does fix some regressions, so I'll give Linus the option of pulling
it in my next pull request. If he declines, we'll put it into -next
and tag it for inclusion into the stable series.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-09-24 17:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 22:32 [PATCH v2 0/4] PCI: allocate space top-down, not bottom-up Bjorn Helgaas
2010-09-17 22:32 ` [PATCH v2 1/4] resources: ensure alignment callback doesn't allocate below available start Bjorn Helgaas
2010-09-24 17:07 ` Jesse Barnes [this message]
2010-09-24 18:15 ` Linus Torvalds
2010-09-24 18:27 ` Jesse Barnes
2010-09-17 22:32 ` [PATCH v2 2/4] x86/PCI: allocate space from the end of a region, not the beginning Bjorn Helgaas
2010-09-17 22:32 ` [PATCH v2 3/4] resources: allocate space within a region from the top down Bjorn Helgaas
2010-09-17 22:32 ` [PATCH v2 4/4] PCI: allocate bus resources " Bjorn Helgaas
2010-09-17 23:46 ` [PATCH v2 0/4] PCI: allocate space top-down, not bottom-up H. Peter Anvin
2010-09-24 22:41 ` Bjorn Helgaas
2010-09-24 23:40 ` [stable] " Greg KH
2010-09-25 0:52 ` Jesse Barnes
2010-09-25 16:30 ` Bjorn Helgaas
2010-09-25 17:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100924100733.2e7fa2ac@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=bjorn.helgaas@hp.com \
--cc=charles.butterfield@nextcentury.com \
--cc=chemobejk@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=phunge0@hotmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox