public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	eugene@redhat.com, linux-kernel@vger.kernel.org, oleg@tv-sign.ru
Subject: Re: [RFC PATCH] proc: making "limits" world readable
Date: Fri, 24 Sep 2010 11:32:46 -0700	[thread overview]
Message-ID: <20100924113246.1221f435.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100924162007.GD30252@hmsreliant.think-freely.org>

On Fri, 24 Sep 2010 12:20:07 -0400
Neil Horman <nhorman@tuxdriver.com> wrote:

> On Fri, Sep 24, 2010 at 12:55:47PM +0200, Jiri Olsa wrote:
> > On Thu, Sep 23, 2010 at 02:56:42PM -0700, Andrew Morton wrote:
> > > On Tue, 21 Sep 2010 11:10:55 +0200
> > > Jiri Olsa <jolsa@redhat.com> wrote:
> > > 
> > > > hi,
> > > > 
> > > > I'd like to have the /proc/<pid>/limits file world readable,
> > > 
> > > Why?
> > > 
> > 
> > having this will ease the task of system management for large install
> > bases and where root privileges might be restricted
> > 
> > jirka
> > 
> I don't see a problem with making this file world readable.  Doing so would be
> in keeping with most of the other stats bearing files in /proc/<pid>.  The only
> reason I didn't make it world readable was because the getrlimit sematics
> previously kept limit information private to the process, and I didn't want to
> deviate from that.  But as long as we're not making it world writeable I think
> we're ok.
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> 

hm, OK, I can't really think of any realistic problem with exposing limits.

The original patch had no signoff.  Please resend, with a changelog
which includes a *good* rationale for making the change.  For example,
a use case.


  reply	other threads:[~2010-09-24 18:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21  9:10 [RFC PATCH] proc: making "limits" world readable Jiri Olsa
2010-09-23 21:56 ` Andrew Morton
2010-09-24 10:55   ` Jiri Olsa
2010-09-24 16:20     ` Neil Horman
2010-09-24 18:32       ` Andrew Morton [this message]
2010-09-27  8:49         ` [PATCHv2] " Jiri Olsa
2010-09-27 10:41           ` Neil Horman
2010-09-27  7:23       ` [RFC PATCH] " Eugene Teo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924113246.1221f435.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=eugene@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox