From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757408Ab0IXSdW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 24 Sep 2010 14:33:22 -0400
Received: from smtp1.linux-foundation.org ([140.211.169.13]:33432 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1757302Ab0IXSdU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Sep 2010 14:33:20 -0400
Date: Fri, 24 Sep 2010 11:32:46 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Jiri Olsa <jolsa@redhat.com>, eugene@redhat.com,
        linux-kernel@vger.kernel.org, oleg@tv-sign.ru
Subject: Re: [RFC PATCH] proc: making "limits" world readable
Message-Id: <20100924113246.1221f435.akpm@linux-foundation.org>
In-Reply-To: <20100924162007.GD30252@hmsreliant.think-freely.org>
References: <1285060255-15784-1-git-send-email-jolsa@redhat.com>
	<20100923145642.49f17b20.akpm@linux-foundation.org>
	<20100924105547.GA1818@jolsa.brq.redhat.com>
	<20100924162007.GD30252@hmsreliant.think-freely.org>
X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 24 Sep 2010 12:20:07 -0400
Neil Horman <nhorman@tuxdriver.com> wrote:

> On Fri, Sep 24, 2010 at 12:55:47PM +0200, Jiri Olsa wrote:
> > On Thu, Sep 23, 2010 at 02:56:42PM -0700, Andrew Morton wrote:
> > > On Tue, 21 Sep 2010 11:10:55 +0200
> > > Jiri Olsa <jolsa@redhat.com> wrote:
> > > 
> > > > hi,
> > > > 
> > > > I'd like to have the /proc/<pid>/limits file world readable,
> > > 
> > > Why?
> > > 
> > 
> > having this will ease the task of system management for large install
> > bases and where root privileges might be restricted
> > 
> > jirka
> > 
> I don't see a problem with making this file world readable.  Doing so would be
> in keeping with most of the other stats bearing files in /proc/<pid>.  The only
> reason I didn't make it world readable was because the getrlimit sematics
> previously kept limit information private to the process, and I didn't want to
> deviate from that.  But as long as we're not making it world writeable I think
> we're ok.
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> 

hm, OK, I can't really think of any realistic problem with exposing limits.

The original patch had no signoff.  Please resend, with a changelog
which includes a *good* rationale for making the change.  For example,
a use case.