public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mat <jackdachef@gmail.com>
Cc: Gabriel C <nix.or.die@googlemail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Jiri Kosina <jkosina@suse.cz>,
	Guillaume Chazarain <guichaz@gmail.com>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Oliver Neukum <oliver@neukum.org>, Alan Ott <alan@signal11.us>,
	linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
	Andreas Bombe <aeb@debian.org>, Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [BUG, Regression, bisected] USB mouse causes bug on 1st insert, ignored on 2nd insert, lsusb stuck at usbdev_open
Date: Fri, 24 Sep 2010 09:46:09 -0700	[thread overview]
Message-ID: <20100924164609.GB16655@kroah.com> (raw)
In-Reply-To: <AANLkTinQVNy4yOSW=aEbuYh6b_F8nKBLxsjxBDk8zq8O@mail.gmail.com>

On Wed, Sep 22, 2010 at 11:47:09AM +0200, Mat wrote:
> On Tue, Sep 21, 2010 at 6:08 PM, Gabriel C <nix.or.die@googlemail.com> wrote:
> > On 21.09.2010 16:54, Phil Turmel wrote:
> >
> >> On 09/21/2010 10:30 AM, Alan Stern wrote:
> >>> On Tue, 21 Sep 2010, Jiri Kosina wrote:
> >>>
> >>>> I have just found out that it's actually CONFIG_USB_DYNAMIC_MINORS which
> >>>> makes the difference. When unset, the problem doesn't trigger, and
> >>>> usb_find_interface() always returns the proper interface. When
> >>>> CONFIG_USB_DYNAMIC_MINORS is being used, the oops happen.
> >>>>
> >>>> I'll look into that.
> >>>
> >>> Apparently the problem is that intf->minors doesn't get initialized
> >>> properly.  This patch should fix it.  Everybody, please try it out.
> >>
> >> Yes, this works for me.  (as did Jiri's version.)
> >
> >
> > Both versions of the patch are working fine for me too also.
> >
> >>
> >> Thank you both for the support.
> >>
> >> Feel free to add my:
> >>
> >> Tested-by: Philip J. Turmel <philip@turmel.org>
> >
> >
> > And mine if you wish.
> > Tested-by: Gabriel Craciunescu  <nix.or.die@googlemail.com>
> >
> >
> 
> confirmed !
> 
> I also tested both and it works fine so far :)
> 
> I don't know if it's too late already:
> Tested-by: Matthias Bayer <jackdachef@gmail.com>

Nope, not to late, I've added this to the patch as well, thanks for
letting us know.

greg k-h

  reply	other threads:[~2010-09-24 16:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20  1:33 [BUG, Regression, bisected] USB mouse causes bug on 1st insert, ignored on 2nd insert, lsusb stuck at usbdev_open Phil Turmel
2010-09-20  9:43 ` Guillaume Chazarain
2010-09-20 10:47   ` Phil Turmel
2010-09-20 12:42   ` Jiri Kosina
2010-09-20 13:19     ` Phil Turmel
2010-09-20 13:25       ` Jiri Kosina
2010-09-20 13:56         ` Mat
2010-09-20 15:10           ` Jiri Kosina
2010-09-20 17:05             ` Mat
2010-09-20 17:40             ` Phil Turmel
2010-09-21 12:31               ` Jiri Kosina
2010-09-21 13:57                 ` Jiri Kosina
2010-09-21 14:48                   ` Heinz Diehl
2010-09-21 14:55                     ` Jiri Kosina
2010-09-21 14:30                 ` Alan Stern
2010-09-21 14:40                   ` Jiri Kosina
2010-09-21 14:42                     ` Phil Turmel
2010-09-21 14:54                   ` Phil Turmel
2010-09-21 16:08                     ` Gabriel C
2010-09-22  9:47                       ` Mat
2010-09-24 16:46                         ` Greg KH [this message]
2010-09-21 16:50                   ` Greg KH
2010-09-21 16:55                     ` Jiri Kosina
2010-09-21 17:07                       ` Greg KH
2010-09-21 17:14                         ` Jiri Kosina
2010-09-20 20:55             ` Alan Stern
2010-09-20 22:48               ` Jiri Kosina
2010-09-21  0:41                 ` Andreas Bombe
2010-09-20 14:11         ` Phil Turmel
2010-09-20 19:35 ` Maciej Rutecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924164609.GB16655@kroah.com \
    --to=greg@kroah.com \
    --cc=aeb@debian.org \
    --cc=alan@signal11.us \
    --cc=gregkh@suse.de \
    --cc=guichaz@gmail.com \
    --cc=jackdachef@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nix.or.die@googlemail.com \
    --cc=oliver@neukum.org \
    --cc=raa.lkml@gmail.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox