From: Don Zickus <dzickus@redhat.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
linux-ide@vger.kernel.org
Subject: Re: hibernation hangs with ATA errors (lockup_detector bug)
Date: Fri, 24 Sep 2010 15:19:46 -0400 [thread overview]
Message-ID: <20100924191946.GS26290@redhat.com> (raw)
In-Reply-To: <4C9CBF4A.9060302@gmail.com>
On Fri, Sep 24, 2010 at 06:10:02PM +0300, Jiri Slaby wrote:
> On 09/03/2010 04:56 PM, Don Zickus wrote:
> > On Fri, Sep 03, 2010 at 10:35:04AM +0200, Jiri Slaby wrote:
> >> On 06/06/2010 08:22 AM, Jiri Slaby wrote:
> >>> On 06/02/2010 08:44 PM, Don Zickus wrote:
> >>>> --- a/kernel/watchdog.c
> >>>> +++ b/kernel/watchdog.c
> >>>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
> >>>> break;
> >>>> case CPU_ONLINE:
> >>>> case CPU_ONLINE_FROZEN:
> >>>> - if (watchdog_enable(hotcpu))
> >>>> - return NOTIFY_BAD;
> >>>> + watchdog_enable(hotcpu)
> >>>
> >>> This fixes the problem indeed.
> >>
> >> Hi, was this fixed somehow? I still use this hunk and don't know if it
> >> is needed:
> >
> > I have to go re-review the problem again. I might have forgot to bring it
> > in. Thanks for reminding me!
>
> Reminder #2 :). Any updates?
Actually there seems to have been some clean up in the cpu hotplug error
handling code. Could you remove that snippet of code and see if the
problem still happens?
Cheers,
Don
next prev parent reply other threads:[~2010-09-24 19:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 14:22 hibernation hangs with ATA errors (lockup_detector bug) Jiri Slaby
2010-06-01 13:50 ` Don Zickus
2010-06-01 14:46 ` Jiri Slaby
2010-06-01 15:26 ` Don Zickus
2010-06-02 18:44 ` Don Zickus
2010-06-02 19:13 ` Frederic Weisbecker
2010-06-02 19:43 ` Frederic Weisbecker
2010-06-03 8:17 ` Tejun Heo
2010-06-02 21:03 ` Don Zickus
2010-06-06 6:22 ` Jiri Slaby
2010-09-03 8:35 ` Jiri Slaby
2010-09-03 13:56 ` Don Zickus
2010-09-24 15:10 ` Jiri Slaby
2010-09-24 18:24 ` Don Zickus
2010-09-24 19:19 ` Don Zickus [this message]
2010-09-25 19:30 ` Jiri Slaby
2010-09-27 14:21 ` Don Zickus
2010-06-01 14:51 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100924191946.GS26290@redhat.com \
--to=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).