From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754481Ab0IXUwK (ORCPT <rfc822;w@1wt.eu>);
	Fri, 24 Sep 2010 16:52:10 -0400
Received: from qmta08.emeryville.ca.mail.comcast.net ([76.96.30.80]:58892 "EHLO
	qmta08.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752237Ab0IXUwI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Sep 2010 16:52:08 -0400
Date: Fri, 24 Sep 2010 13:51:08 -0700
From: matt mooney <mfm@muteddisk.com>
To: T Dent <tdent48227@gmail.com>
Cc: matt mooney <mfmooney@gmail.com>, greg@kroah.com,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines
Message-ID: <20100924205108.GA8191@haskell.muteddisk.com>
Mail-Followup-To: T Dent <tdent48227@gmail.com>,
	matt mooney <mfmooney@gmail.com>, greg@kroah.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <AANLkTikqf4rn6BP2gyQAuQrvt7EdFY8yfa+o8nfR9xWE@mail.gmail.com>
 <AANLkTikvGGz+33ni=Kov1qM1DpSj2WVuk89u=TwE9iL_@mail.gmail.com>
 <AANLkTin1YfwwVcDNUBsi34iYC6HA5Y6+uOFZN=+Q2hqs@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTin1YfwwVcDNUBsi34iYC6HA5Y6+uOFZN=+Q2hqs@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16:39 Fri 24 Sep     , T Dent wrote:
> On 9/24/10, matt mooney <mfmooney@gmail.com> wrote:
> > On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote:
> >> I changed every makefile in the staging directory to use the proper
> >> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) .
> >
> > Um, you didn't do a lot of these right. Maybe you should look into why
> > the change was made in the first place. For semantic reasons, I was
> > also changing the first assignment to ":=" from "+=".
> 
> I can resend them with the a small modification to the patch files if you want.

After looking at more of them, my "a lot" was a little bit of an
overstatement. The first few I randomly looked at happen to use the incorrect
pattern, but most are simple without relying on a variable. Yeah, I think you
should resubmit with a "[PATCH v2]." The pattern is:

ifeq ($(FOO),y)
     EXTRA_CFLAGS := <flags>
endif

changes to:

ccflags-$(FOO) := <flags>

Also, the rest of the kernel tree has been done except drivers/media; however, I
am going to email them in a little bit asking if some consolidation is possible
due to every driver there relying on a few flags. So thanks for the help (though
is was a good thing I was saving staging for last)!

-mfm