Re: [PATCH 10/10] Fs: ext4: namei: fixed file of checkpatch/pl warnings and errors

Krzysztof Halasa
2010-09-26T06:36:47Z

Tracey Dent <tdent48227@gmail.com> writes:

> + printk("%s%3u:%03u hash %8x/%8x ", levels ? "":" ", i, block, hash, range);
> + if (!(bh = ext4_bread(NULL,dir, block, 0,&err))) continue;

Put a SPACE after the comma. "continue" should usually be on the next
line. It doesn't make sense to fix the formatting only partially.

BTW I wouldn't trust checkpatch so blindly. Also keep in mind checkpatch
is only a tool and that maintainers have full authority to ignore the
problems (or "problems") it spews.
And I would merge all the changes (which make sense) and send them in
one patch - that should increase the odds of it actually being applied.
To be honest, fixing the style isn't an easy job.
--
Krzysztof Halasa