From: "Ted Ts'o" <tytso@mit.edu>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Christoph Hellwig <hch@lst.de>, T Dent <tdent48227@gmail.com>,
adilger.kernel@dilger.ca, jack@suse.cz, dmonakhov@openvz.org,
sandeen@redhat.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue
Date: Sat, 25 Sep 2010 21:53:28 -0400 [thread overview]
Message-ID: <20100926015328.GI19690@thunk.org> (raw)
In-Reply-To: <1285464746.6115.108.camel@Joe-Laptop>
On Sat, Sep 25, 2010 at 06:32:26PM -0700, Joe Perches wrote:
> On Sat, 2010-09-25 at 21:04 -0400, Ted Ts'o wrote:
> > But the stupid thing is
> > trying to do it on a file-by-file basis in the first place, when for
> > something like fs/ext4, it really should be done on a subdirectory
> > basis.
>
> That's not true at all.
No, it *is* true. Someone with brains, as supposed to a stupid
script, would know that fs/ext4 should be treated as a unit. And
there *is* a F: fs/ext4 in the MAINTAINERS script.
Yet the "git-fallback" code still persisted in analyzing fs/ext4/acl.c
as a file by itself, and not as a subdirectory. That's WRONG. That's
not what Linus was telling you to do, if you're going to use that
e-mail of his as an excuse.
I'm glad you're now turning it off (at least by default) if there is a
MAINTAINER entry, but that code (disabled or not) is broken as it is.
You really need human intelligence to know whether to do things
file-by-file, or directory-by-directory. And if you can't figure it
out on your own, then the script shouldn't even try, or give a huge
warning that it's madly guessing and may be totally incorrect about
who you're telling the newbie to spam with their bug report.
> > I at least never use it.
>
> Nor are you required to.
>
> Tool use is optional. I don't care if you carve
> patches with a mallet onto stone tablets and send
> them by swarms of carrier pigeon to Linus so can
> reuse the stone to build an actual castle.
Yes, but the newbies don't know that they shouldn't use it, becuase it
can be wrong. And training them not to use their God-given brains,
instead of using a stupid script, is what I'm objecting to. That's
why I said, I'm not sure that get_maintainers.pl has an excuse for
existing. At least checkpatch.pl has some valid uses, even if it is
occasionaly abused.
I don't believe get_maintainers.pl does have legitmate use, since it's
really not that hard to look up something in MAINTAINERS, and if it's
not there, some real human judgement is needed, and not hueristic
guessing --- or at the very least, the script needs to warn that it's
guessing, and maybe explain to the user in detail why it's making the
guesses that it's making, so the user has a chance of understanding
why it might be completely wrong.
- Ted
next prev parent reply other threads:[~2010-09-26 1:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 18:31 [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Tracey Dent
2010-09-25 18:31 ` [PATCH 02/10] Fs: ext4: acl.h: whitespace cleanup Tracey Dent
2010-09-26 6:11 ` Krzysztof Halasa
2010-09-25 18:31 ` [PATCH 03/10] Fs: ext: balloc: fixed a few issues that checkpatch.pl was having Tracey Dent
2010-09-25 18:31 ` [PATCH 04/10] Fs: ext4: block_validity: added space around = sign Tracey Dent
2010-09-25 18:31 ` [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl Tracey Dent
2010-09-26 6:23 ` Krzysztof Halasa
2010-09-25 18:31 ` [PATCH 06/10] Fs: ext4: extents: whitespace cleanup Tracey Dent
2010-09-25 18:31 ` [PATCH 07/10] Fs: ext4: file: fixed indent problem Tracey Dent
2010-09-25 18:31 ` [PATCH 08/10] Fs: ext4: ioctl: fixed spacing issue Tracey Dent
2010-09-25 18:32 ` [PATCH 09/10] Fs: ext4: mballoc.c: whitespace cleanup Tracey Dent
2010-09-25 18:32 ` [PATCH 10/10] Fs: ext4: namei: fixed file of checkpatch/pl warnings and errors Tracey Dent
2010-09-26 6:36 ` Krzysztof Halasa
2010-09-26 18:23 ` Ted Ts'o
2010-09-26 18:35 ` Davidlohr Bueso
2010-09-26 19:17 ` Krzysztof Halasa
2010-09-25 23:36 ` [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Christoph Hellwig
2010-09-25 23:53 ` T Dent
2010-09-25 23:56 ` Christoph Hellwig
2010-09-26 0:01 ` Ted Ts'o
2010-09-26 0:09 ` Joe Perches
2010-09-26 0:32 ` Ted Ts'o
2010-09-26 0:36 ` Ted Ts'o
2010-09-26 0:50 ` Joe Perches
2010-09-26 0:58 ` Joe Perches
2010-09-26 6:42 ` Krzysztof Halasa
2010-09-26 6:49 ` Joe Perches
2010-09-26 11:31 ` Krzysztof Halasa
2010-09-26 1:04 ` Ted Ts'o
2010-09-26 1:32 ` Joe Perches
2010-09-26 1:53 ` Ted Ts'o [this message]
2010-09-26 2:03 ` Joe Perches
2010-09-26 2:10 ` Ted Ts'o
2010-09-26 2:21 ` Ted Ts'o
2010-09-26 2:45 ` Joe Perches
2010-09-26 2:29 ` Joe Perches
2010-09-26 0:06 ` Joe Perches
2010-09-26 20:06 ` Christoph Hellwig
2010-09-26 22:17 ` Joe Perches
2010-09-25 23:54 ` Ted Ts'o
2010-09-27 13:52 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926015328.GI19690@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=apw@canonical.com \
--cc=dmonakhov@openvz.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=joe@perches.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox