From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Marek Belisko <marek.belisko@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix error path
Date: Sun, 26 Sep 2010 15:11:51 +0200 [thread overview]
Message-ID: <20100926131151.GC6134@bicker> (raw)
In-Reply-To: <1285491595-377-1-git-send-email-segooon@gmail.com>
On Sun, Sep 26, 2010 at 12:59:55PM +0400, Vasiliy Kulikov wrote:
> +err_free:
> + for (i--; i>=0; i--) {
> + kfree(pdpram_blk->pbuffer);
> + kfree(pdpram_blk);
> + }
This is wrong. I don't have linux-next so I can't see the context, why
are we looping here? The second iteration through the loop will cause a
NULL dereference.
Also there should be spaces before and after the ">=".
regards,
dan carpenter
> + return STATUS_FAILURE;
> }
>
next prev parent reply other threads:[~2010-09-26 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 8:59 [PATCH] staging: ft1000: fix error path Vasiliy Kulikov
2010-09-26 13:11 ` Dan Carpenter [this message]
2010-09-26 16:56 ` Belisko Marek
2010-09-26 17:18 ` walter harms
2010-09-26 19:41 ` Vasiliy Kulikov
2010-10-03 17:58 ` [PATCH v2] " Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926131151.GC6134@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox