* 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
@ 2010-09-26 21:17 Thomas Meyer
2010-09-26 22:40 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Meyer @ 2010-09-26 21:17 UTC (permalink / raw)
To: Linux Kernel Mailing List, jbeulich, r.marek, guenter.roeck
$ make V=2
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh - due to target is PHONY
CHK include/generated/compile.h
CC [M] drivers/hwmon/coretemp.o - due to target missing
drivers/hwmon/coretemp.c: In function 'coretemp_device_remove':
drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
make[2]: *** [drivers/hwmon/coretemp.o] Error 1
make[1]: *** [drivers/hwmon] Error 2
make: *** [drivers] Error 2
above function is not defined on UP.
This commit introduced the error:
commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f
Author: Jan Beulich <jbeulich@novell.com>
Date: Mon Sep 13 10:23:05 2010 +0000
x86/hwmon: register alternate sibling upon CPU removal
Just like pkgtemp registers another core of the same package when one
gets removed, coretemp should register another hyperthread (if
available) in that situation.
As pointed out in the patch fixing the respective code in pkgtemp, the
list protectng mutex must be dropped before calling
coretemp_device_add(), and due to the restructured loop (including an
explicit return) the "safe" variant of the list iterator isn't needed
anymore.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
2010-09-26 21:17 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask' Thomas Meyer
@ 2010-09-26 22:40 ` Randy Dunlap
2010-09-26 22:52 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-09-26 22:40 UTC (permalink / raw)
To: Thomas Meyer; +Cc: Linux Kernel Mailing List, jbeulich, r.marek, guenter.roeck
On Sun, 26 Sep 2010 23:17:50 +0200 Thomas Meyer wrote:
> $ make V=2
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh - due to target is PHONY
> CHK include/generated/compile.h
> CC [M] drivers/hwmon/coretemp.o - due to target missing
> drivers/hwmon/coretemp.c: In function 'coretemp_device_remove':
> drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
> make[2]: *** [drivers/hwmon/coretemp.o] Error 1
> make[1]: *** [drivers/hwmon] Error 2
> make: *** [drivers] Error 2
>
> above function is not defined on UP.
Patch just posted:
http://lkml.org/lkml/2010/9/26/112
> This commit introduced the error:
>
> commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f
> Author: Jan Beulich <jbeulich@novell.com>
> Date: Mon Sep 13 10:23:05 2010 +0000
>
> x86/hwmon: register alternate sibling upon CPU removal
>
> Just like pkgtemp registers another core of the same package when one
> gets removed, coretemp should register another hyperthread (if
> available) in that situation.
>
> As pointed out in the patch fixing the respective code in pkgtemp, the
> list protectng mutex must be dropped before calling
> coretemp_device_add(), and due to the restructured loop (including an
> explicit return) the "safe" variant of the list iterator isn't needed
> anymore.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Rudolf Marek <r.marek@assembler.cz>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
2010-09-26 22:40 ` Randy Dunlap
@ 2010-09-26 22:52 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2010-09-26 22:52 UTC (permalink / raw)
To: Randy Dunlap
Cc: Thomas Meyer, Linux Kernel Mailing List, jbeulich@novell.com,
r.marek@assembler.cz
On Sun, Sep 26, 2010 at 06:40:11PM -0400, Randy Dunlap wrote:
> On Sun, 26 Sep 2010 23:17:50 +0200 Thomas Meyer wrote:
>
> > $ make V=2
> > CHK include/linux/version.h
> > CHK include/generated/utsrelease.h
> > CALL scripts/checksyscalls.sh - due to target is PHONY
> > CHK include/generated/compile.h
> > CC [M] drivers/hwmon/coretemp.o - due to target missing
> > drivers/hwmon/coretemp.c: In function 'coretemp_device_remove':
> > drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
> > make[2]: *** [drivers/hwmon/coretemp.o] Error 1
> > make[1]: *** [drivers/hwmon] Error 2
> > make: *** [drivers] Error 2
> >
> > above function is not defined on UP.
>
> Patch just posted:
>
> http://lkml.org/lkml/2010/9/26/112
>
>
... with apologies
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-26 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-26 21:17 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask' Thomas Meyer
2010-09-26 22:40 ` Randy Dunlap
2010-09-26 22:52 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox