* [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined
@ 2010-09-26 19:50 Guenter Roeck
2010-09-27 6:25 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2010-09-26 19:50 UTC (permalink / raw)
To: lm-sensors, linux-kernel, torvalds
Cc: Ingo Molnar, Fenghua Yu, Jean Delvare, Guenter Roeck
Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
a build breakage if CONFIG_SMP is undefined. This patch
fixes the problem.
Reported-by: Ingo Molnar <mingo@elte.hu>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---
drivers/hwmon/coretemp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index baa842a..58a3c2d 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu)
list_del(&p->list);
mutex_unlock(&pdev_list_mutex);
kfree(p);
+#ifdef CONFIG_SMP
for_each_cpu(i, cpu_sibling_mask(cpu))
if (i != cpu && !coretemp_device_add(i))
break;
+#endif
return;
}
mutex_unlock(&pdev_list_mutex);
--
1.7.0.87.g0901d
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined
2010-09-26 19:50 [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
@ 2010-09-27 6:25 ` Ingo Molnar
2010-09-27 11:48 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2010-09-27 6:25 UTC (permalink / raw)
To: Guenter Roeck
Cc: lm-sensors, linux-kernel, torvalds, Fenghua Yu, Jean Delvare
* Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> a build breakage if CONFIG_SMP is undefined. This patch
> fixes the problem.
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
>
> ---
> drivers/hwmon/coretemp.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index baa842a..58a3c2d 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu)
> list_del(&p->list);
> mutex_unlock(&pdev_list_mutex);
> kfree(p);
> +#ifdef CONFIG_SMP
> for_each_cpu(i, cpu_sibling_mask(cpu))
> if (i != cpu && !coretemp_device_add(i))
> break;
> +#endif
Wont this result in an 'unused variable i' compiler warning?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined
2010-09-27 6:25 ` Ingo Molnar
@ 2010-09-27 11:48 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2010-09-27 11:48 UTC (permalink / raw)
To: Ingo Molnar
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, Fenghua Yu, Jean Delvare
On Mon, Sep 27, 2010 at 02:25:10AM -0400, Ingo Molnar wrote:
>
> * Guenter Roeck <guenter.roeck@ericsson.com> wrote:
>
> > Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> > a build breakage if CONFIG_SMP is undefined. This patch
> > fixes the problem.
> >
> > Reported-by: Ingo Molnar <mingo@elte.hu>
> > Cc: Fenghua Yu <fenghua.yu@intel.com>
> > Cc: Jean Delvare <khali@linux-fr.org>
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> >
> > ---
> > drivers/hwmon/coretemp.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index baa842a..58a3c2d 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu)
> > list_del(&p->list);
> > mutex_unlock(&pdev_list_mutex);
> > kfree(p);
> > +#ifdef CONFIG_SMP
> > for_each_cpu(i, cpu_sibling_mask(cpu))
> > if (i != cpu && !coretemp_device_add(i))
> > break;
> > +#endif
>
> Wont this result in an 'unused variable i' compiler warning?
>
Sigh. Yes, of course. Must have been blind when I compiled it. Serves me right,
for pushing this out in a hurry. You'll see rev2 of the patch in a minute.
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-27 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-26 19:50 [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-27 6:25 ` Ingo Molnar
2010-09-27 11:48 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox