From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Mattias Wallin <mattias.wallin@stericsson.com>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: Declare abx500_remove_ops()
Date: Mon, 27 Sep 2010 15:29:39 +0200 [thread overview]
Message-ID: <20100927132938.GG2560@sortiz-mobl> (raw)
In-Reply-To: <1285163910-1789-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Wed, Sep 22, 2010 at 02:58:30PM +0100, Mark Brown wrote:
> Otherwise sparse warns about a public symbol with no declaration and
> the compiler can't spot if the callers and users have different signatures
> for the function.
Patch applied, thanks for spotting this.
Cheers,
Samuel.
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/linux/mfd/abx500.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h
> index be7373c..67bd6f7 100644
> --- a/include/linux/mfd/abx500.h
> +++ b/include/linux/mfd/abx500.h
> @@ -229,4 +229,5 @@ struct abx500_ops {
> };
>
> int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops);
> +void abx500_remove_ops(struct device *dev);
> #endif
> --
> 1.7.1
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-09-27 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 13:58 [PATCH] mfd: Declare abx500_remove_ops() Mark Brown
2010-09-22 14:22 ` Mattias Wallin
2010-09-27 13:29 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927132938.GG2560@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.wallin@stericsson.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox