Re: [PATCH] Update num_symtab, symtab and strtab right after setup of core_num_syms, core_symtab and core_strtab.

[Hu Tao <hutao@cn.fujitsu.com>]

On Mon, Sep 27, 2010 at 04:54:25PM +0800, Américo Wang wrote:
> On Mon, Sep 27, 2010 at 04:22:47PM +0800, Hu Tao wrote:
> >On Mon, Sep 27, 2010 at 04:09:54PM +0800, Américo Wang wrote:
> >> On Mon, Sep 27, 2010 at 03:30:28PM +0800, Hu Tao wrote:
> >> >Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> >> 
> >> 
> >> Changelog is empty.
> >> What bug did you observe?
> >
> >symtab and strtab will point to vfreed memory after free_copy(&info)
> >near end of load_module().
> >
> 
> I think you must mean the error path in load_module(), yeah, probably.

No. There is a free_copy(&info) at the end of normal path of load_module().

> 
> But you need to check if this patch misses other thing, like
> the other functions which are called after add_kallsyms() inside load_module().
> According to my eyes, this seems fine (at least on x86), so
> 
> Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

Thanks for review.

> 
> >> 
> >> 
> >> This patch is not correct, symbols that are not core symbols will be
> >> dropped right after this piece of code. So NACK.
> >
> >There is the reason why we should update num_symtab, symtab and strtab
> >before non-core-symbols are dropped.
> 
> init section is dropped *after* these value are update, which is correct.
> 
> Again, you need to describe what you are trying to fix in your changelog.
> Please resend it with a proper changelog.
> 
> Thanks.