From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pekka Enberg <penberg@kernel.org>, Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined
Date: Mon, 27 Sep 2010 18:12:06 -0700 [thread overview]
Message-ID: <20100928011206.GA5159@ericsson.com> (raw)
In-Reply-To: <AANLkTi=m5ZtWhQ6Z69WPUkyvcqhmL1ewG1gZ0HUQB3LE@mail.gmail.com>
On Mon, Sep 27, 2010 at 09:00:59PM -0400, Linus Torvalds wrote:
> On Mon, Sep 27, 2010 at 5:26 PM, Guenter Roeck
> <guenter.roeck@ericsson.com> wrote:
> >
> > Not that simple. cpu_sibling_mask() is defined in asm/smp.h, which is only
> > included from linux/smp.h if SMP is defined. But many other files do include
> > asm/smp.h directly. This causes the following error all over the place
> > if CONFIG_SMP is not defined.
>
> Yeah, that's broken. Seriously broken.
>
> And I guess that if you had happened to include <asm/smp.h> in
> coretemp.c you would magically have gotten that cpu_sibling_map()
> thing, and it would just work - by mistake.
>
Figured.
> And maybe that's the correct (and really hacky) fix right now. Rather
Yes, that is actually what I am testing right now.
> than introduce an UP-only cpu_sibling_mask(), get the SMP version, and
> get it ignored.
>
> Seriously broken, but there it is.
>
> In the long run, I guess we should either
> - disallow naked '<asm/smp.h>' includes
> OR
> - just make '<linux/smp.h>' unconditionally include <asm/smp.h>
>
> to at least not have that insane "some things exist in CONFIG_SMP or
> not depending on how you include files".
>
Guess so.
You should get another patch in a few minutes, after my next set of compiles is done.
I'll wait for some feedback before pushing it into my integration branch.
Guenter
next prev parent reply other threads:[~2010-09-28 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 11:59 [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-27 12:59 ` Ingo Molnar
2010-09-27 13:02 ` Pekka Enberg
2010-09-27 23:27 ` Guenter Roeck
2010-09-27 23:44 ` Linus Torvalds
2010-09-28 0:07 ` Guenter Roeck
2010-09-28 0:26 ` Guenter Roeck
2010-09-28 1:00 ` Linus Torvalds
2010-09-28 1:12 ` Guenter Roeck [this message]
2010-09-27 13:15 ` Guenter Roeck
2010-09-27 14:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928011206.GA5159@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=fenghua.yu@intel.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox