[PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

[PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

[Guenter Roeck]

Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
a build breakage if CONFIG_SMP is undefined. This commit
fixes the problem.

Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
---
v2: Fix compile warning due to unused variable i if SMP is undefined
v3: include asm/smp.h instead of using ifdef CONFIG_SMP

 drivers/hwmon/coretemp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index baa842a..a23b17a 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -36,6 +36,7 @@
 #include <linux/pci.h>
 #include <asm/msr.h>
 #include <asm/processor.h>
+#include <asm/smp.h>
 
 #define DRVNAME	"coretemp"
 
-- 
1.7.0.87.g0901d

Re: [PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

[Ingo Molnar]

* Guenter Roeck <guenter.roeck@ericsson.com> wrote:

> Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> a build breakage if CONFIG_SMP is undefined. This commit
> fixes the problem.

This commit works around the problem in a hacky but not-so-ugly way.

( You might also want to include Linus's suggestion about how to fix it 
  for real in the future - so that we have at least some kind of record 
  of it. )

> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>

FYI, while i dont care about my Reported-by's but you lost a Reported-by 
tag here - you should be as careful about them as about your own 
signoffs.

> v2: Fix compile warning due to unused variable i if SMP is undefined 
> v3: include asm/smp.h instead of using ifdef CONFIG_SMP

I've started testing this fix - but i'd expect it to fix the problem - 
so consider it fixed unless i report back within a few hours that 
there's some breakage left.

Thanks,

	Ingo

Re: [PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

[Ingo Molnar]

* Ingo Molnar <mingo@elte.hu> wrote:

> > v2: Fix compile warning due to unused variable i if SMP is undefined 
> > v3: include asm/smp.h instead of using ifdef CONFIG_SMP
> 
> I've started testing this fix [...]

Works fine here.

Tested-by: Ingo Molnar <mingo@elte.hu>

Thanks,

	Ingo

Re: [PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

[Guenter Roeck]

On Tue, Sep 28, 2010 at 06:14:08AM -0400, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > > v2: Fix compile warning due to unused variable i if SMP is undefined 
> > > v3: include asm/smp.h instead of using ifdef CONFIG_SMP
> > 
> > I've started testing this fix [...]
> 
> Works fine here.
> 
> Tested-by: Ingo Molnar <mingo@elte.hu>
> 
Great - thanks for your time!

Guenter

Re: [PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

[Guenter Roeck]

On Tue, Sep 28, 2010 at 04:27:29AM -0400, Ingo Molnar wrote:
> 
> * Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> 
> > Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> > a build breakage if CONFIG_SMP is undefined. This commit
> > fixes the problem.
> 
> This commit works around the problem in a hacky but not-so-ugly way.
> 
> ( You might also want to include Linus's suggestion about how to fix it 
>   for real in the future - so that we have at least some kind of record 
>   of it. )
> 
Done.

> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > Cc: Fenghua Yu <fenghua.yu@intel.com>
> 
> FYI, while i dont care about my Reported-by's but you lost a Reported-by 
> tag here - you should be as careful about them as about your own 
> signoffs.
> 
Added it back in.

Thanks,
Guenter