From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753184Ab0I1L0z (ORCPT ); Tue, 28 Sep 2010 07:26:55 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:35240 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752870Ab0I1L0x (ORCPT ); Tue, 28 Sep 2010 07:26:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=LAtvnO1gAPAMm3lZEZ3fUvkLiNfT4rFpoJFIRZDZJ+jvfZQzpYRIZikBH/txvpHYao ii+85LzlGm0wVow1yEN48HrZtSJQgGf0Jqv5s7FchNa9P1OS/sN3FaZBYBEhX6wzMI9Y XmWdmRNXazsbeFUuSQ3nvu6Hy9qros7vJJ1u0= Date: Tue, 28 Sep 2010 15:26:43 +0400 From: Anton Vorontsov To: Felipe Balbi Cc: Grazvydas Ignotas , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Chikkature Rajashekar, Madhusudhan" , Arun Murthy Subject: Re: [PATCH v4] power_supply: Add driver for TWL4030/TPS65950 BCI charger Message-ID: <20100928112643.GC22734@oksana.dev.rtsoft.ru> References: <1285618704-8985-1-git-send-email-notasas@gmail.com> <20100928060554.GF2702@legolas.emea.dhcp.ti.com> <20100928084251.GC3900@legolas.emea.dhcp.ti.com> <20100928090637.GD3900@legolas.emea.dhcp.ti.com> <20100928094122.GA7081@legolas.emea.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20100928094122.GA7081@legolas.emea.dhcp.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2010 at 12:41:22PM +0300, Felipe Balbi wrote: > On Tue, Sep 28, 2010 at 04:39:17AM -0500, Grazvydas Ignotas wrote: > >On Tue, Sep 28, 2010 at 12:06 PM, Felipe Balbi wrote: > >>On Tue, Sep 28, 2010 at 04:02:48AM -0500, Grazvydas Ignotas wrote: > >>>> > >>>>Charger event is SENT by charger driver when it verifies it's attached > >>>>to a wall charger. > >>> > >>>Isn't that a job for musb/gadget? Detecting D+/D- being shorted by > >>>charger or something like that? I don't think BCI is able to detect > >>>charger. > >> > >>it's part of the charger detection right ? and according to trm, it's on > >>the BCI (actually BCC) role to take care of that :-) > > > >Hm you are probably talking about TWL5031, which has redesigned > >charger block that is named BCC. TWL4030 charger is different, called > >BCI and requires software charger detection from what I see in it's > >TRM. > > ok, might be that I got confused. Then it's ok the way it is. So we need > other means to detect the charger :-p May we consider this as a minor issue that can be improved later? If so, I would like to apply it, but I'll wait a day or two for Reviewed-by or Acked-by tags to give the proper credits. Thanks! -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2