Re: [PATCH -v2 6/7] x86, NMI, Add support to notify hardware error with unknown NMI

Huang Ying
2010-09-28T01:54:24Z

On Mon, 2010-09-27 at 23:38 +0800, Don Zickus wrote:
> Hi Huang,
>
> On Mon, Sep 27, 2010 at 08:57:05AM +0800, Huang Ying wrote:
> > @@ -360,6 +362,14 @@ io_check_error(unsigned char reason, str
> > static notrace __kprobes void
> > unknown_nmi_error(unsigned char reason, struct pt_regs *regs)
> > {
> > + /*
> > + * On some platforms, hardware errors may be notified via
> > + * unknown NMI
> > + */
> > + if (unknown_nmi_for_hwerr)
> > + panic("NMI for hardware error without error record: "
> > + "Not continuing");
>
> Can you modify this to let users know to check the BIOS/BMC for further
> messages? Otherwise people just file bugzillas asking what the problem
> is, and the first thing we have to respond with is check the BIOS/BMC.

Sorry, forget about that. Will change it in next version.

Best Regards,
Huang Ying