Re: [PATCH -v2 6/7] x86, NMI, Add support to notify hardware error with unknown NMI

Robert Richter
2010-09-28T15:27:59Z

On 27.09.10 21:19:21, Huang Ying wrote:
> On Mon, 2010-09-27 at 21:38 +0800, Robert Richter wrote:
> > On 27.09.10 08:47:53, huang ying wrote:
> >
> > > >> arch/x86/kernel/hwerr.c | 55 +++++++++++++++++++++++++++++++++++++++++++++
> > > >
> > > > Instead of creating this file the code should be implemented in
> > > >
> > > > arch/x86/kernel/cpu/intel.c
> > > >
> > > > Similar AMD NB code is implemented in amd.c and k8.c.
> > >
> > > Why? This file is not vendor specific.
> >
> > No, it only implements an Intel specific PCI device, nothing else.
>
> You can add AMD specific PCI device here too. We will add more device ID
> in the future.

I think it is not worth to introduce this file. There is no generic
code in and we have over places for vendor specific code.

> No. We do NOT catch unknown NMIs for a certain hardware here. We put the
> code here because we think it is general instead of hardware specific.
>
> It should be a general rule to treat unknown NMI as hardware error. But
> to avoid to confuse some users have broken hardware (which will generate
> unknown NMI not for hardware error), we use a white list (machines with
> HEST or workable chipset via PCI ID).

Ok, a white list makes sense. This was not obvious in your
implementation.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center