Re: [PATCH -v2 4/7] x86, NMI, Rewrite NMI handler

Robert Richter
2010-09-27T22:35:21Z

On 27.09.10 15:14:33, Don Zickus wrote:
> Actually, looking through the handlers, by introducing priorities means
> that people have to register multiple handlers to deal with the different
> priorities.
>
> For example, perf would need two handlers, one for DIE_NMI and one for
> DIE_NMIUNKOWN. I am not sure that is the way to go.

Ok, this could be a problem for handlers dealing with both DIE_NMI and
DIE_NMI_UNKNOW. But without priorities as it is implemented now, the
handlers are called in registration order or even without any order.
So I don't think we need this fine grained priorities for different
cases. If we have priorities, the order would be always the same for
all chains, which should be fine for most cases.

> I would be inclined to leave the patch as is until we can come up with a
> better way to handle the priorities.
>
> Though I agree that DIE_NMI_IPI isn't a great name (doesn't it all go
> through the local apic?), it isn't being introduced with this patch.
>
> Thoughts?

At least we should give the above a try. If it turns out it is not as
easy as I think, the still can fall back. But if we could finally get
rid of DIE_NMI_IPI, this would eas much.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center