From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
Andrew Morton <akpm@linux-foundation.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Alek Du <alek.du@intel.com>,
richard.rojfors@mocean-labs.com, meego-dev@meego.com,
ML linux-kernel <linux-kernel@vger.kernel.org>,
Qi <qi.wang@intel.com>,
andrew.chih.howe.khor@intel.com, gregkh@suse.de,
Yong Y <yong.y.wang@intel.com>,
Tomoya MORINAGA <morinaga526@dsn.okisemi.com>,
joel.clark@intel.com, margie.foster@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_GPIO driver to 2.6.35
Date: Tue, 28 Sep 2010 09:28:40 -0700 [thread overview]
Message-ID: <20100928162839.GA10739@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <001201cb5ed7$6117cb40$66f8800a@maildom.okisemi.com>
On Tue, Sep 28, 2010 at 03:35:39PM +0900, Masayuki Ohtake wrote:
> gpio->base = (u32)chip->pch_gpio_base_address;
This is the number that will be assigned to the first GPIO if the chip
registers successfully.
> gpio->ngpio = 12;
This is the number of GPIOs your chip has.
> chip->pch_gpio_base_address = pci_iomap(pdev, 1, 0);
This initialisation is incorrect and is likely to fail. gpiolib knows
nothing of how your chip is controlled, the base is the base for the
GPIO numbers used to access GPIOs in gpiolib. Please refer to other
gpiolib drivers for examples of how to use the gpilib APIs.
next prev parent reply other threads:[~2010-09-28 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 10:54 [MeeGo-Dev][PATCH] Topcliff: Update PCH_GPIO driver to 2.6.35 Masayuki Ohtak
2010-09-03 13:48 ` Mark Brown
[not found] ` <000301cb5ebc$35ad8d20$66f8800a@maildom.okisemi.com>
2010-09-28 3:38 ` Mike Frysinger
2010-09-28 4:57 ` Masayuki Ohtake
2010-09-28 5:02 ` Mike Frysinger
2010-09-28 5:25 ` Masayuki Ohtake
2010-09-28 5:29 ` Mark Brown
2010-09-28 6:35 ` Masayuki Ohtake
2010-09-28 16:28 ` Mark Brown [this message]
2010-09-28 5:32 ` Mike Frysinger
2010-09-28 7:21 ` Masayuki Ohtake
2010-09-28 4:12 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-08-10 10:59 Masayuki Ohtak
2010-08-10 17:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928162839.GA10739@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=alek.du@intel.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=gregkh@suse.de \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=qi.wang@intel.com \
--cc=randy.dunlap@oracle.com \
--cc=richard.rojfors@mocean-labs.com \
--cc=sameo@linux.intel.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox