From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Masayuki Ohtak <masa-korg@dsn.okisemi.com>
Cc: meego-dev@meego.com, "Andrew Morton" <akpm@linux-foundation.org>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Randy Dunlap" <randy.dunlap@oracle.com>,
"Alek Du" <alek.du@intel.com>,
"Richard Röjfors" <richard.rojfors@mocean-labs.com>,
"Mike Frysinger" <vapier@gentoo.org>,
linux-kernel@vger.kernel.org, qi.wang@intel.com,
andrew.chih.howe.khor@intel.com, kok.howg.ewe@intel.com,
joel.clark@intel.com, yong.y.wang@intel.com,
"Tomoya MORINAGA" <morinaga526@dsn.okisemi.com>,
margie.foster@intel.com
Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_GPIO driver to 2.6.35
Date: Tue, 28 Sep 2010 10:58:09 -0700 [thread overview]
Message-ID: <20100928175808.GG10739@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CA1B775.9020809@dsn.okisemi.com>
On Tue, Sep 28, 2010 at 06:37:57PM +0900, Masayuki Ohtak wrote:
> + gpio->base = (u32)chip->pch_gpio_base_address;
> + chip->reg = chip->pch_gpio_base_address;
The GPIO base passed to gpiolib should be the base GPIO number for the
device, not the address of the control registers. Normally this would
be passed in via platform data or set to -1 to allow the core to assign
a slot.
prev parent reply other threads:[~2010-09-28 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 9:37 [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_GPIO driver to 2.6.35 Masayuki Ohtak
2010-09-28 14:55 ` Mike Frysinger
2010-09-28 17:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928175808.GG10739@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=alek.du@intel.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=qi.wang@intel.com \
--cc=randy.dunlap@oracle.com \
--cc=richard.rojfors@mocean-labs.com \
--cc=sameo@linux.intel.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox