From: Jarod Wilson <jarod@redhat.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Manu Abraham <abraham.manu@gmail.com>,
Scott Davilla <davilla@4pi.com>,
Lars Lindley <lindley@coyote.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: crystalhd: fix signed bug
Date: Tue, 28 Sep 2010 15:01:26 -0400 [thread overview]
Message-ID: <20100928190126.GG8726@redhat.com> (raw)
In-Reply-To: <1284317813-4895-1-git-send-email-segooon@gmail.com>
On Sun, Sep 12, 2010 at 10:56:51PM +0400, Vasiliy Kulikov wrote:
> chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense.
> Since it is used as signed, declare it as int.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Indeed, Bad Things here when we try to store the ret from register_chrdev
in an unsigned int and test it for < 0...
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2010-09-28 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 18:56 [PATCH] staging: crystalhd: fix signed bug Vasiliy Kulikov
2010-09-28 19:01 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928190126.GG8726@redhat.com \
--to=jarod@redhat.com \
--cc=abraham.manu@gmail.com \
--cc=davilla@4pi.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox