From: Al Viro <viro@ZenIV.linux.org.uk>
To: Michael Cree <mcree@orcon.net.nz>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org, mattst88@gmail.com,
torvalds@linux-foundation.org
Subject: Re: [PATCH 1/2] alpha: switch osf_sigprocmask() to use of sigprocmask()
Date: Wed, 29 Sep 2010 02:07:38 +0100 [thread overview]
Message-ID: <20100929010738.GJ19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4CA1B7DF.10202@orcon.net.nz>
On Tue, Sep 28, 2010 at 10:39:43PM +1300, Michael Cree wrote:
> On 27/09/10 07:28, Al Viro wrote:
> >
> >get rid of a useless wrapper, while we are at it
> >
> >Signed-off-by: Al Viro<viro@zeniv.linux.org.uk>
>
> Compiling this leads to the following errors:
>
> arch/alpha/kernel/signal.c: In function ?SYSC_osf_sigprocmask?:
> arch/alpha/kernel/signal.c:52: error: implicit declaration of
> function ?siprocmask?
> arch/alpha/kernel/signal.c:55: error: invalid type argument of ?->?
> (have ?sigset_t?)
>
> Obviously it should be sigprocmask at line 52, and presumably line
> 55 which is currently
>
> res = oldmask->sig[0];
>
> should be
>
> res = oldmask.sig[0];
Grrrr.... My apologies - cherry-pick from the wrong branch ;-/
Al "nothing like seeing the errors one has fixed show up in what's sent" Viro
next prev parent reply other threads:[~2010-09-29 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 18:28 [PATCH 1/2] alpha: switch osf_sigprocmask() to use of sigprocmask() Al Viro
2010-09-28 9:39 ` Michael Cree
2010-09-29 1:07 ` Al Viro [this message]
2010-09-30 7:39 ` Michael Cree
2010-09-30 11:50 ` Al Viro
2010-09-30 11:56 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929010738.GJ19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mcree@orcon.net.nz \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox