RE: [PATCH 5/9 v2] ARM: S3C64XX: add support for mach-mini6410

Kukjin Kim
2010-10-19T07:07:56Z

Darius Augulis wrote:
>
> Add support for mini6410 board from FriendlyARM
>
> Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
> ---
>
> Changelog since v1:
> - Ben's comments about coding style fixed
>
> arch/arm/mach-s3c64xx/Kconfig | 10 ++
> arch/arm/mach-s3c64xx/Makefile | 1
> arch/arm/mach-s3c64xx/mach-mini6410.c | 157
> +++++++++++++++++++++++++++++++++
> 3 files changed, 168 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-s3c64xx/mach-mini6410.c
>

(snip)

> +
> +MACHINE_START(MINI6410, "MINI6410")
> + /* Maintainer: Darius Augulis <augulis.darius@gmail.com> */
> + .phys_io = S3C_PA_UART & 0xfff00000,
> + .io_pg_offst = (((u32)S3C_VA_UART) >> 18) & 0xfffc,

Now, we no need to add above two members since commit 861bd81ee62a0d6759144c22909a8a3938951656 ("arm: remove machine_desc.io_pg_offst and .phys_io") from the arm tree

> + .boot_params = S3C64XX_PA_SDRAM + 0x100,
> +
> + .init_irq = s3c6410_init_irq,
> + .map_io = mini6410_map_io,
> + .init_machine = mini6410_machine_init,
> + .timer = &s3c24xx_timer,
> +MACHINE_END

Others, looks ok.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.