Re: [PATCH 3/4] cs5535: add some additional cs5535-specific GPIO functionality

[Andres Salomon <dilinger@queued.net>]

On Wed, 29 Sep 2010 18:05:01 -0700
Greg KH <greg@kroah.com> wrote:

> On Sat, Sep 25, 2010 at 07:07:12PM -0700, Andres Salomon wrote:
> > 
> > This adds (well, re-adds actually) handling for events/IRQs through
> > cs5535 GPIOs.  In the wild and wooly world of CS5535, setup_event()
> > is for assigning an IRQ to a GPIO filter/event pair, and set_irq()
> > sets up the pair to trigger IRQs.
> > 
> > These should really only be used in highly platform-specific
> > drivers (such as OLPC's DCON driver).  Sadly, because set_irq()
> > uses MSRs, this causes the driver to become X86-specific.
> > 
> > Signed-off-by: Andres Salomon <dilinger@queued.net>
> > ---
> >  drivers/gpio/Kconfig       |    2 +-
> >  drivers/gpio/cs5535-gpio.c |   52
> > ++++++++++++++++++++++++++++++++++++++++++++
> > include/linux/cs5535.h     |    2 +
> 
> I can't take this change without the gpio subsystem maintainer acking
> it.  Can you get that approval from them?


I believe the GPIO subsystem is unmaintained (please correct me if
I'm wrong).   David Brownell had some good input on my original
cs5535-gpio driver patches that I sent, so I'll Cc him.  I
think that's as close to a maintainer as we're going to get. :)

If I recall correctly, the past few of my (and others') cs5535-gpio
patches have gone in by way of the -mm tree.


> 
> I'm guessing that your 4/4 patch here depends on it, right?  If so,

Correct.


> I'll hold off on applying that patch until we can figure out how to
> handle this, ok?
> 
> thanks,
> 
> greg k-h