From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177Ab0I3Cqo (ORCPT ); Wed, 29 Sep 2010 22:46:44 -0400 Received: from LUNGE.MIT.EDU ([18.54.1.69]:54111 "EHLO lunge.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452Ab0I3Cqm (ORCPT ); Wed, 29 Sep 2010 22:46:42 -0400 Date: Wed, 29 Sep 2010 19:46:50 -0700 From: Andres Salomon To: Greg KH Cc: Greg KH , devel@driverdev.osuosl.org, dsd@laptop.org, jon.nettleton@gmail.com, linux-geode@lists.infradead.org, linux-kernel@vger.kernel.org, cjb@laptop.org, David Brownell Subject: Re: [PATCH 3/4] cs5535: add some additional cs5535-specific GPIO functionality Message-ID: <20100929194650.7283174c@debxo> In-Reply-To: <20100930010501.GA28145@kroah.com> References: <20100925190712.6aa5c2fc@debxo> <20100930010501.GA28145@kroah.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Sep 2010 18:05:01 -0700 Greg KH wrote: > On Sat, Sep 25, 2010 at 07:07:12PM -0700, Andres Salomon wrote: > > > > This adds (well, re-adds actually) handling for events/IRQs through > > cs5535 GPIOs. In the wild and wooly world of CS5535, setup_event() > > is for assigning an IRQ to a GPIO filter/event pair, and set_irq() > > sets up the pair to trigger IRQs. > > > > These should really only be used in highly platform-specific > > drivers (such as OLPC's DCON driver). Sadly, because set_irq() > > uses MSRs, this causes the driver to become X86-specific. > > > > Signed-off-by: Andres Salomon > > --- > > drivers/gpio/Kconfig | 2 +- > > drivers/gpio/cs5535-gpio.c | 52 > > ++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/cs5535.h | 2 + > > I can't take this change without the gpio subsystem maintainer acking > it. Can you get that approval from them? I believe the GPIO subsystem is unmaintained (please correct me if I'm wrong). David Brownell had some good input on my original cs5535-gpio driver patches that I sent, so I'll Cc him. I think that's as close to a maintainer as we're going to get. :) If I recall correctly, the past few of my (and others') cs5535-gpio patches have gone in by way of the -mm tree. > > I'm guessing that your 4/4 patch here depends on it, right? If so, Correct. > I'll hold off on applying that patch until we can figure out how to > handle this, ok? > > thanks, > > greg k-h