From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379Ab0I2XUg (ORCPT ); Wed, 29 Sep 2010 19:20:36 -0400 Received: from qmta15.emeryville.ca.mail.comcast.net ([76.96.27.228]:52830 "EHLO qmta15.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998Ab0I2XUe (ORCPT ); Wed, 29 Sep 2010 19:20:34 -0400 Date: Wed, 29 Sep 2010 16:19:04 -0700 From: matt mooney To: Sam Ravnborg Cc: Michal Marek , Randy Dunlap , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt Message-ID: <20100929231904.GB21930@haskell.muteddisk.com> Mail-Followup-To: Sam Ravnborg , Michal Marek , Randy Dunlap , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1284964412-32211-1-git-send-email-mfm@muteddisk.com> <4CA35541.9090106@suse.cz> <20100929175031.GA9278@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100929175031.GA9278@merkur.ravnborg.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19:50 Wed 29 Sep , Sam Ravnborg wrote: > On Wed, Sep 29, 2010 at 05:03:29PM +0200, Michal Marek wrote: > > On 20.9.2010 08:33, matt mooney wrote: > > > Change $(src) and $(obj) definitions to state the path as absolute and > > > not relative. > > > > It _is_ a relative patch, AFAICS. What makes you think otherwise? > > With extenal modules $(src) and $(obj) are absolute - but in nomal use they are relative. > And again in normal use they are also equal. I usually say that we have two just to document > what is srource and what is generated. Ah, I see. Sorry, I should have looked into this more. Now you did say in normal use they are equal, but I thought they were also equal when used for an external module too. Am I missing something? Thanks, mfm