From: Greg KH <greg@kroah.com>
To: David Cross <david.cross@cypress.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Staging: west bridge, cyasgadget fix for usb_gadget_probe_driver
Date: Wed, 29 Sep 2010 18:37:00 -0700 [thread overview]
Message-ID: <20100930013700.GA22193@kroah.com> (raw)
In-Reply-To: <1285287600.17888.2.camel@odc-laptop>
On Thu, Sep 23, 2010 at 05:20:00PM -0700, David Cross wrote:
> This patch fixes the west bridge cyasgadget driver in order to allow for
> compilation against the linux-next tree. This changes
> usb_gadget_register_driver to usb_gadget_probe_driver and updates this
> function based on the new function definition (bind call).
>
> Signed-off-by: David Cross <david.cross@cypress.com>
>
> --- linux-next-vanilla/drivers/staging/westbridge/astoria/gadget/cyasgadget.c 2010-09-20 23:40:58.000000000 -0700
> +++ linux-next-incremen/drivers/staging/westbridge/astoria/gadget/cyasgadget.c 2010-09-23 16:54:32.000000000 -0700
> @@ -1882,9 +1882,8 @@ static void cyas_ep0_start(
> * disconnect is reported. then a host may connect again, or
> * the driver might get unbound.
> */
> -int usb_gadget_register_driver(
> - struct usb_gadget_driver *driver
> - )
> +int usb_gadget_probe_driver(struct usb_gadget_driver *driver,
> + int (*bind)(struct usb_gadget *))
> {
> cyasgadget *dev = cy_as_gadget_controller ;
> int retval;
> @@ -1898,7 +1897,7 @@ int usb_gadget_register_driver(
> * "must not be used in normal operation"
> */
> if (!driver
> - || !driver->bind
> + || !bind
> || !driver->unbind
> || !driver->setup)
> return -EINVAL;
> @@ -1919,7 +1918,7 @@ int usb_gadget_register_driver(
> cyas_usb_reset(dev) ; /* External usb */
> cyas_usb_reinit(dev) ; /* Internal */
>
> - retval = driver->bind(&dev->gadget);
> + retval = bind(&dev->gadget);
> if (retval) {
> #ifndef WESTBRIDGE_NDEBUG
> cy_as_hal_print_message("%s bind to driver %s --> %d\n",
> @@ -1938,7 +1937,7 @@ int usb_gadget_register_driver(
>
> return 0;
> }
> -EXPORT_SYMBOL(usb_gadget_register_driver);
> +EXPORT_SYMBOL(usb_gadget_probe_driver);
That's a pretty generic name you are exporting, I'd recommend changing
this very soon...
thanks,
greg k-h
next prev parent reply other threads:[~2010-09-30 1:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 0:20 [PATCH] west bridge, cyasgadget fix for usb_gadget_probe_driver David Cross
2010-09-30 1:37 ` Greg KH [this message]
[not found] ` <1285287885.17888.7.camel@odc-laptop>
2010-10-06 1:44 ` [PATCH] west bridge cyasgadget, removal of " " before ";" David Cross
2010-10-06 1:48 ` [PATCH] west bridge, addition of common lock on cyasdevice David Cross
2010-10-06 1:50 ` [PATCH] west bridge, block driver change for partition support David Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930013700.GA22193@kroah.com \
--to=greg@kroah.com \
--cc=david.cross@cypress.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox