From: Greg KH <greg@kroah.com>
To: walter harms <wharms@bfs.de>
Cc: Tracey Dent <tdent48227@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/22] Staging: rtl8187se: Makefile: cleaned up makefile cflag lines
Date: Wed, 29 Sep 2010 23:18:52 -0700 [thread overview]
Message-ID: <20100930061852.GA8707@kroah.com> (raw)
In-Reply-To: <4C9DD2A4.6080508@bfs.de>
On Sat, Sep 25, 2010 at 12:44:52PM +0200, walter harms wrote:
>
>
> Tracey Dent schrieb:
> > Changed to use proper ccflags-y option
> >
> > Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> > ---
> > drivers/staging/rtl8187se/Makefile | 20 ++++++++++----------
> > 1 files changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile
> > index e6adf91..51fbd24 100644
> > --- a/drivers/staging/rtl8187se/Makefile
> > +++ b/drivers/staging/rtl8187se/Makefile
> > @@ -1,20 +1,20 @@
> >
> > -#EXTRA_CFLAGS += -DCONFIG_IEEE80211_NOWEP=y
> > -#EXTRA_CFLAGS += -std=gnu89
> > -#EXTRA_CFLAGS += -O2
> > +#ccflags-y := -DCONFIG_IEEE80211_NOWEP=y
> > +#ccflags-y := -std=gnu89
> > +#ccflags-y := -O2
> > #CC = gcc
> >
> > -EXTRA_CFLAGS += -DSW_ANTE
> > -EXTRA_CFLAGS += -DTX_TRACK
> > -EXTRA_CFLAGS += -DHIGH_POWER
> > -EXTRA_CFLAGS += -DSW_DIG
> > -EXTRA_CFLAGS += -DRATE_ADAPT
> > +ccflags-y := -DSW_ANTE
> > +ccflags-y := -DTX_TRACK
> > +ccflags-y := -DHIGH_POWER
> > +ccflags-y := -DSW_DIG
> > +ccflags-y := -DRATE_ADAPT
> >
> > #enable it for legacy power save, disable it for leisure power save
> > -EXTRA_CFLAGS += -DENABLE_LPS
> > +ccflags-y := -DENABLE_LPS
> >
> >
> > -#EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
> > +#ccflags-y := -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
> >
>
> I do not understand this. If CONFIG_FORCE_HARD_FLOAT is required by the
> driver so he should fail if CONFIG_FORCE_HARD_FLOAT=n
> Or you need to protect the -mhard-float with an if().
That line is commented out, it doesn't do anything, so I wouldn't worry
about it :)
thanks,
greg k-h
next prev parent reply other threads:[~2010-09-30 6:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 23:27 [PATCH v2 01/22] Staging: cx25821: Makefile:cleaned up makefile cflag lines Tracey Dent
2010-09-24 23:27 ` [PATCH v2 02/22] Staging: cxlel: Makefile: cleaned " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 03/22] Staging: dream: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 04/22] Staging: dream: camera: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 05/22] Staging: dream: qdsp5: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 06/22] Staging: easycap: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 07/22] Staging: go7007: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 08/22] Staging: otus: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 09/22] Staging: rt2860: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 10/22] Staging: rt2870: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 11/22] Staging: rtl8187se: " Tracey Dent
2010-09-25 10:44 ` walter harms
2010-09-30 6:18 ` Greg KH [this message]
2010-09-24 23:28 ` [PATCH v2 12/22] Staging: rt8192e: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 13/22] Staging: rtl8192su: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 14/22] Staging: rtl8192su: ieee80211: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 15/22] Staging: rtl8192u: " Tracey Dent
2010-09-25 10:52 ` walter harms
2010-09-30 6:19 ` Greg KH
2010-09-24 23:28 ` [PATCH v2 16/22] Staging: rtl8192u: ieee80211: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 17/22] Staging: tm6000: Makefile: changed " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 18/22] Staging: usbip: Makefile: cleaned " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 19/22] Staging: vt6655: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 20/22] Staging: vt6656: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 21/22] Staging: wlags49_h2: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 22/22] Staging: wlags49_h25: " Tracey Dent
2010-09-25 10:28 ` [PATCH v2 01/22] Staging: cx25821: Makefile:cleaned " Sam Ravnborg
2010-09-30 6:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930061852.GA8707@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).