From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: lenb@kernel.org, rui.zhang@intel.com, melchior+kernel@cmu.edu,
jerone.young@canonical.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, patrol@sinus.cz, "Lee,
Chun-Yi" <jlee@novell.com>
Subject: Re: [PATCH] DMI to disable Vista compatibility on MSI GX723 Notebook
Date: Thu, 30 Sep 2010 14:25:52 +0100 [thread overview]
Message-ID: <20100930132552.GA11064@srcf.ucam.org> (raw)
In-Reply-To: <1285843451-24932-1-git-send-email-jlee@novell.com>
On Thu, Sep 30, 2010 at 06:44:11PM +0800, Lee, Chun-Yi wrote:
> The brightness control hotkey don't work with Vista compatibility
> , because MSI GX723 included a infinite while loop in DSDT when
> brightness control hotkey pressed.
> MSI GX723 used Nvida video card, the infinite while loop must be a
> workaround with Nvidia's Vista driver.
While this would work, it seems likely that the expected behaviour is
for the graphics driver to call the NVIF method. We don't do that as
yet, but when we do I'm worried about it potentially resulting in this
system being in an unexpected state (NVIF is used, but we don't claim to
be Vista). Can you add a comment indicating that it should be reverted
once nouveau grows support?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-09-30 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 10:44 [PATCH] DMI to disable Vista compatibility on MSI GX723 Notebook Lee, Chun-Yi
2010-09-30 13:25 ` Matthew Garrett [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-01 8:48 Joey Lee
2010-10-01 19:42 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930132552.GA11064@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jerone.young@canonical.com \
--cc=jlee@novell.com \
--cc=joeyli.kernel@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=melchior+kernel@cmu.edu \
--cc=patrol@sinus.cz \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox