From: Nikanth Karthikesan <knikanth@suse.de>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] Assign CPUs to nodes in round-robin manner on Fake NUMA.
Date: Thu, 30 Sep 2010 17:34:10 +0530 [thread overview]
Message-ID: <201009301734.10787.knikanth@suse.de> (raw)
Assign CPUs to nodes in round-robin manner on Fake NUMA.
commit d9c2d5ac6af87b4491bff107113aaf16f6c2b2d9
"x86, numa: Use near(er) online node instead of roundrobin for NUMA"
changed NUMA initialization on Intel to choose the nearest online node or
first node. Fake NUMA would be better of with round-robin initialization,
instead of the all CPUS on first node. Change the choice of first node, back
to round-robin.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 85f69cd..47dd171 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -283,9 +283,7 @@ static void __cpuinit srat_detect_node(struct cpuinfo_x86 *c)
/* Don't do the funky fallback heuristics the AMD version employs
for now. */
node = apicid_to_node[apicid];
- if (node == NUMA_NO_NODE)
- node = first_node(node_online_map);
- else if (!node_online(node)) {
+ if (node == NUMA_NO_NODE || !node_online(node)) {
/* reuse the value from init_cpu_to_node() */
node = cpu_to_node(cpu);
}
next reply other threads:[~2010-09-30 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 12:04 Nikanth Karthikesan [this message]
2010-10-07 7:42 ` [PATCH] Assign CPUs to nodes in round-robin manner on Fake NUMA Andrew Morton
2010-10-08 5:53 ` Nikanth Karthikesan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009301734.10787.knikanth@suse.de \
--to=knikanth@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox