From: Andrew Morton <akpm@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@novell.com>, Ingo Molnar <mingo@elte.hu>,
heukelum@fastmail.fm, tglx@linutronix.de,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: gas 2.16 and assembly macros -- entry_64.S build failure
Date: Thu, 30 Sep 2010 18:01:00 -0700 [thread overview]
Message-ID: <20100930180100.4607034f.akpm@linux-foundation.org> (raw)
In-Reply-To: <4CA52AA5.5040402@zytor.com>
On Thu, 30 Sep 2010 17:26:13 -0700 "H. Peter Anvin" <hpa@zytor.com> wrote:
> On 09/16/2010 04:21 AM, Jan Beulich wrote:
> >>
> >> Yes, to only generate CFI on binutils that allows us to write sane
> >> looking code.
> >>
> >> I.e. to disable CONFIG_AS_CFI on binutils that are broken for this.
> >
> > Again - that won't help, as it's the macro invocation that gas
> > fails one, not one of the actual .cfi_* directives.
> >
>
> Looking again at this issue with the binutils version from hell
> (sigh)... I'm running quickly out of ideas.
>
> The problem is that cpp inserts spaces around expansions, so:
>
> pushq_cfi $(USER_DS)
>
> ... turns into something like ...
>
> pushq_cfi $( ( 5 * 8 + 3 ) )
>
> ... which these old versions of gas considers multiple arguments to the
> macro, even though there is no comma anywhere.
Could we run another little program after cpp which takes the spaces
out again?
next prev parent reply other threads:[~2010-10-01 1:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201009152110.o8FLAJeJ015584@imap1.linux-foundation.org>
[not found] ` <4C91F07E0200007800016B50@vpn.id2.novell.com>
[not found] ` <20100916082816.GA25681@elte.hu>
[not found] ` <4C91F3A30200007800016B64@vpn.id2.novell.com>
[not found] ` <20100916101355.GA31458@elte.hu>
[not found] ` <4C9219BC0200007800016C53@vpn.id2.novell.com>
2010-10-01 0:26 ` gas 2.16 and assembly macros -- entry_64.S build failure H. Peter Anvin
2010-10-01 1:01 ` Andrew Morton [this message]
2010-10-01 1:48 ` H. Peter Anvin
2010-10-01 8:27 ` Jan Beulich
2010-10-01 15:21 ` H. Peter Anvin
2010-10-01 15:46 ` Jan Beulich
2010-10-01 17:21 ` H. Peter Anvin
2010-10-04 7:36 ` Jan Beulich
2010-10-04 10:04 ` Avi Kivity
2010-10-04 15:43 ` H. Peter Anvin
2010-10-04 16:20 ` Avi Kivity
2010-10-04 18:23 ` H. Peter Anvin
2010-10-05 7:48 ` Avi Kivity
2010-10-05 7:51 ` Ingo Molnar
2010-10-05 9:09 ` Avi Kivity
2010-10-19 10:13 ` Jan Beulich
2010-10-19 10:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930180100.4607034f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=JBeulich@novell.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox