From: Greg KH <gregkh@suse.de>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: Greg KH <greg@kroah.com>,
kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org,
Marek Belisko <marek.belisko@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix skb, netdev, memory leaks
Date: Thu, 30 Sep 2010 12:53:07 -0700 [thread overview]
Message-ID: <20100930195307.GA30952@suse.de> (raw)
In-Reply-To: <20100930192303.GA10342@albatros>
On Thu, Sep 30, 2010 at 11:23:03PM +0400, Vasiliy Kulikov wrote:
> On Thu, Sep 30, 2010 at 04:13 -0700, Greg KH wrote:
> > On Tue, Sep 28, 2010 at 09:49:35PM +0400, Vasiliy Kulikov wrote:
> > > ft1000_copy_up_pkt() doesn't free skb on errors.
> > > init_ft1000_card() doesn't free netdev with free_netdev() but with kfree().
> > > init_ft1000_card() doesn't check request_region()'s return value
> > > and doesn't free region on error.
> > >
> > > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> > > ---
> > > Compile tested.
> >
> > No you didn't
>
> No I did:
>
> make -C /home/vasya/linux drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.o
> make: Вход в каталог `/home/vasya/dev/linux-next'
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CC drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.o
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c: In function ‘ft1000_reset_card’:
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:525: warning: passing argument 2 of ‘card_download’ discards qualifiers from pointer target type
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:56: note: expected ‘void *’ but argument is of type ‘const u8 * const’
> make: Выход из каталога `/home/vasya/dev/linux-next'
Heh, I didn't think to try that, amazed that it worked at all.
> However,
>
> cd ../drivers/staging/ft1000/ft1000-pcmcia/
> LANG=C make -C ~/linux ft1000_hw.o
> make: Entering directory `/home/vasya/dev/linux-next'
> make: *** No rule to make target `ft1000_hw.o'. Stop.
> make: Leaving directory `/home/vasya/dev/linux-next'
>
>
> Is "make" from linux root buggy/not supported for staging/everything?
This driver is marked broken, look at the Kconfig file:
config FT1000_PCMCIA
tristate "Driver for ft1000 pcmcia device."
depends on PCMCIA && BROKEN
It will be fixed up soon hopefully.
thanks,
greg k-h
next prev parent reply other threads:[~2010-09-30 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 17:49 [PATCH] staging: ft1000: fix skb, netdev, memory leaks Vasiliy Kulikov
2010-09-30 11:13 ` Greg KH
2010-09-30 19:23 ` Vasiliy Kulikov
2010-09-30 19:53 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-26 8:59 Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930195307.GA30952@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox