From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756279Ab0JDPXQ (ORCPT ); Mon, 4 Oct 2010 11:23:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30742 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033Ab0JDPXP (ORCPT ); Mon, 4 Oct 2010 11:23:15 -0400 Date: Thu, 30 Sep 2010 16:19:14 -0400 From: Jarod Wilson To: Geert Uytterhoeven Cc: Mauro Carvalho Chehab , Andrew Morton , Linux Kernel Development , linux-media@vger.kernel.org Subject: Re: [PATCH] lirc: Make struct file_operations pointer const Message-ID: <20100930201914.GD8135@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2010 at 09:55:07PM +0200, Geert Uytterhoeven wrote: > struct file_operations was made const in the drivers, but not in struct > lirc_driver: > > drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards qualifiers from pointer target type > drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards qualifiers from pointer target type > drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards qualifiers from pointer target type > drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards qualifiers from pointer target type > drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards qualifiers from pointer target type > > Signed-off-by: Geert Uytterhoeven Whoops, yeah, obvious fix. Acked-by: Jarod Wilson -- Jarod Wilson jarod@redhat.com