* [PATCH] lirc: Make struct file_operations pointer const
@ 2010-09-30 19:55 Geert Uytterhoeven
2010-09-30 20:19 ` Jarod Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2010-09-30 19:55 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Jarod Wilson
Cc: Andrew Morton, Linux Kernel Development, linux-media
struct file_operations was made const in the drivers, but not in struct
lirc_driver:
drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards qualifiers from pointer target type
drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards qualifiers from pointer target type
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
include/media/lirc_dev.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/media/lirc_dev.h b/include/media/lirc_dev.h
index b1f6066..71a896e 100644
--- a/include/media/lirc_dev.h
+++ b/include/media/lirc_dev.h
@@ -139,7 +139,7 @@ struct lirc_driver {
struct lirc_buffer *rbuf;
int (*set_use_inc) (void *data);
void (*set_use_dec) (void *data);
- struct file_operations *fops;
+ const struct file_operations *fops;
struct device *dev;
struct module *owner;
};
--
1.7.0.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] lirc: Make struct file_operations pointer const
2010-09-30 19:55 [PATCH] lirc: Make struct file_operations pointer const Geert Uytterhoeven
@ 2010-09-30 20:19 ` Jarod Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Jarod Wilson @ 2010-09-30 20:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Andrew Morton, Linux Kernel Development,
linux-media
On Thu, Sep 30, 2010 at 09:55:07PM +0200, Geert Uytterhoeven wrote:
> struct file_operations was made const in the drivers, but not in struct
> lirc_driver:
>
> drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards qualifiers from pointer target type
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Whoops, yeah, obvious fix.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-04 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 19:55 [PATCH] lirc: Make struct file_operations pointer const Geert Uytterhoeven
2010-09-30 20:19 ` Jarod Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox