From: Dave Jones <davej@redhat.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: dave@gnu.org, cpufreq@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
x86 maintainers <x86@kernel.org>
Subject: Re: [RESEND PATCH] cpufreq: unnecesary double free in pcc_cpufreq_do_osc
Date: Fri, 1 Oct 2010 01:25:41 -0400 [thread overview]
Message-ID: <20101001052540.GA31519@redhat.com> (raw)
In-Reply-To: <4CA567DB.4000208@kernel.org>
On Fri, Oct 01, 2010 at 07:47:23AM +0300, Pekka Enberg wrote:
> > I think Dave's patch is correct. There's a kfree(output.pointer) at line 359.
> > If we fall all the way through without hitting any of the return -ENODEVs,
> > we end up doing a 2nd kfree in the out_free:
>
> There's a second call to acpi_evaluate_object() which takes "output" as
> its argument and allocates more memory.
yup. I merged your patch. after it's soaked in -next for a day, I'll push it to
Linus. (Looks obviously correct, but just being extra careful given where
we are in the release cycle)
Dave
next prev parent reply other threads:[~2010-10-01 5:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 19:43 [RESEND PATCH] cpufreq: unnecesary double free in pcc_cpufreq_do_osc Davidlohr Bueso
2010-09-30 19:59 ` Pekka Enberg
2010-09-30 20:06 ` Dave Jones
2010-10-01 4:47 ` Pekka Enberg
2010-10-01 5:25 ` Dave Jones [this message]
2010-09-30 20:06 ` David Rientjes
2010-09-30 20:02 ` David Rientjes
2010-09-30 20:08 ` Dave Jones
2010-09-30 20:17 ` Davidlohr Bueso
2010-09-30 20:15 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001052540.GA31519@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=dave@gnu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox