From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
Richard Purdie <rpurdie@linux.intel.com>,
Alberto Panizzo <maramaopercheseimorto@gmail.com>,
Valentin Longchamp <valentin.longchamp@epfl.ch>
Subject: Re: [PATCH 3/4] mfd/mc13xxx: add support for mc13892
Date: Fri, 1 Oct 2010 13:02:33 +0200 [thread overview]
Message-ID: <20101001110233.GG784@pengutronix.de> (raw)
In-Reply-To: <20101001104250.GB3064@sortiz-mobl>
On Fri, Oct 01, 2010 at 12:42:51PM +0200, Samuel Ortiz wrote:
> Hi Uwe,
>
> On Wed, Sep 29, 2010 at 06:23:46PM +0200, Uwe Kleine-König wrote:
> > mc13892 is the companion PMIC for Freescale's i.MX51. It's similar enough
> > to mc13782 to support it in a single driver.
> >
> > This patch introduces enough compatibility cruft to keep all users of the
> > superseded mc13783 driver unchanged.
> All 4 patches applied, thanks.
Thanks.
> I have one comment though:
>
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index db51ea1..1868d9b 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -408,11 +408,16 @@ config MFD_PCF50633
> > so that function-specific drivers can bind to them.
> >
> > config MFD_MC13783
> > - tristate "Support Freescale MC13783"
> > + tristate
> > +
> I don't think it's worth keeping this symbol around.
That's part of the compatibility cruft because some drivers depend on
it. This will be removed when all other drivers are converted together
with (e.g.) include/mfd/mc13783.h.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-10-01 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 16:23 [PATCH 0/4] mfd/mc13xxx: cleanups and support for mc13892 Uwe Kleine-König
2010-09-29 16:23 ` [PATCH 1/4] mfd/mc13783: remove obsolete private data Uwe Kleine-König
2010-09-29 16:23 ` [PATCH 2/4] mfd/mc13783: remove deprecated functions Uwe Kleine-König
2010-09-29 16:23 ` [PATCH 3/4] mfd/mc13xxx: add support for mc13892 Uwe Kleine-König
2010-10-01 10:42 ` Samuel Ortiz
2010-10-01 11:02 ` Uwe Kleine-König [this message]
2010-10-01 13:06 ` Samuel Ortiz
2010-10-01 13:19 ` Uwe Kleine-König
2010-10-01 13:02 ` [Customers.Protonic] " David Jander
2010-10-07 18:45 ` Uwe Kleine-König
2010-10-07 18:49 ` Samuel Ortiz
2010-10-19 9:26 ` Samuel Ortiz
2010-09-29 16:23 ` [PATCH 4/4] rtc/mc13xxx: add support for the rtc found in the MC13892 PMIC Uwe Kleine-König
2010-10-01 7:38 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001110233.GG784@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maramaopercheseimorto@gmail.com \
--cc=rpurdie@linux.intel.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox