Re: [PATCH 3/4] mfd/mc13xxx: add support for mc13892

[Samuel Ortiz <sameo@linux.intel.com>]

On Fri, Oct 01, 2010 at 01:02:33PM +0200, Uwe Kleine-König wrote:
> On Fri, Oct 01, 2010 at 12:42:51PM +0200, Samuel Ortiz wrote:
> > Hi Uwe,
> > 
> > On Wed, Sep 29, 2010 at 06:23:46PM +0200, Uwe Kleine-König wrote:
> > > mc13892 is the companion PMIC for Freescale's i.MX51.  It's similar enough
> > > to mc13782 to support it in a single driver.
> > > 
> > > This patch introduces enough compatibility cruft to keep all users of the
> > > superseded mc13783 driver unchanged.
> > All 4 patches applied, thanks.
> Thanks.
>  
> > I have one comment though:
> > 
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > index db51ea1..1868d9b 100644
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -408,11 +408,16 @@ config MFD_PCF50633
> > >  	  so that function-specific drivers can bind to them.
> > >  
> > >  config MFD_MC13783
> > > -	tristate "Support Freescale MC13783"
> > > +	tristate
> > > +
> > I don't think it's worth keeping this symbol around.
> That's part of the compatibility cruft because some drivers depend on
> it.  
Right, there are 4 of them left, I didnt see that.

> This will be removed when all other drivers are converted together
> with (e.g.) include/mfd/mc13783.h.
It would be nice to have them ready for the next merge window, and I suppose
this should go through my tree then.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/