public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Alan Cox <alan@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tobias Klauser <tklauser@distanz.ch>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] altera_uart: Add support for polling mode (IRQ-less)
Date: Fri, 1 Oct 2010 17:21:33 +0400	[thread overview]
Message-ID: <20101001132133.GB25897@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20101001132045.GA9649@oksana.dev.rtsoft.ru>

Some Altera UART implementations doesn't route the IRQ line, so we have
to work in polling mode.

Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
---
 drivers/serial/altera_uart.c |   23 ++++++++++++++++++++++-
 1 files changed, 22 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/altera_uart.c b/drivers/serial/altera_uart.c
index f8d8a00..7dd58da 100644
--- a/drivers/serial/altera_uart.c
+++ b/drivers/serial/altera_uart.c
@@ -15,6 +15,7 @@
 
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/timer.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/console.h>
@@ -76,6 +77,7 @@
  */
 struct altera_uart {
 	struct uart_port port;
+	struct timer_list tmr;
 	unsigned int sigs;	/* Local copy of line sigs */
 	unsigned short imr;	/* Local IMR mirror */
 };
@@ -168,6 +170,7 @@ static void altera_uart_set_termios(struct uart_port *port,
 	tty_termios_encode_baud_rate(termios, baud, baud);
 
 	spin_lock_irqsave(&port->lock, flags);
+	uart_update_timeout(port, termios->c_cflag, baud);
 	writel(baudclk, port->membase + ALTERA_UART_DIVISOR_REG);
 	spin_unlock_irqrestore(&port->lock, flags);
 }
@@ -268,6 +271,15 @@ static irqreturn_t altera_uart_interrupt(int irq, void *data)
 	return IRQ_RETVAL(isr);
 }
 
+static void altera_uart_timer(unsigned long data)
+{
+	struct uart_port *port = (void *)data;
+	struct altera_uart *pp = container_of(port, struct altera_uart, port);
+
+	altera_uart_interrupt(0, port);
+	mod_timer(&pp->tmr, jiffies + uart_poll_timeout(port));
+}
+
 static void altera_uart_config_port(struct uart_port *port, int flags)
 {
 	port->type = PORT_ALTERA_UART;
@@ -284,6 +296,12 @@ static int altera_uart_startup(struct uart_port *port)
 	unsigned long flags;
 	int ret;
 
+	if (!port->irq) {
+		setup_timer(&pp->tmr, altera_uart_timer, (unsigned long)port);
+		mod_timer(&pp->tmr, jiffies + uart_poll_timeout(port));
+		return 0;
+	}
+
 	ret = request_irq(port->irq, altera_uart_interrupt, IRQF_DISABLED,
 			DRV_NAME, port);
 	if (ret) {
@@ -316,7 +334,10 @@ static void altera_uart_shutdown(struct uart_port *port)
 
 	spin_unlock_irqrestore(&port->lock, flags);
 
-	free_irq(port->irq, port);
+	if (port->irq)
+		free_irq(port->irq, port);
+	else
+		del_timer_sync(&pp->tmr);
 }
 
 static const char *altera_uart_type(struct uart_port *port)
-- 
1.7.0.5


  parent reply	other threads:[~2010-10-01 13:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-01 13:20 [PATCH v2 0/8] Some patches for Altera UART driver Anton Vorontsov
2010-10-01 13:21 ` [PATCH 1/8] serial: Factor out uart_poll_timeout() from 8250 driver Anton Vorontsov
2010-10-01 13:21 ` Anton Vorontsov [this message]
2010-10-01 13:57   ` [PATCH 2/8] altera_uart: Add support for polling mode (IRQ-less) Tobias Klauser
2010-10-01 13:21 ` [PATCH 3/8] altera_uart: Add support for getting mapbase and IRQ from resources Anton Vorontsov
2010-10-01 13:21 ` [PATCH 4/8] altera_uart: Add support for different address strides Anton Vorontsov
2010-10-01 14:01   ` Tobias Klauser
2010-10-01 13:22 ` [PATCH 5/8] altera_uart: Make it possible to use Altera UART and 8250 ports together Anton Vorontsov
2010-10-01 12:41   ` Alan Cox
2010-10-01 13:52     ` Anton Vorontsov
2010-10-01 14:18       ` Alan Cox
2010-10-01 15:22         ` Anton Vorontsov
2010-10-01 14:57           ` Alan Cox
2010-10-01 16:05             ` Anton Vorontsov
2010-10-01 14:23   ` [PATCH v3 " Anton Vorontsov
2010-10-01 13:22 ` [PATCH 6/8] altera_uart: Fixup type usage of port flags Anton Vorontsov
2010-10-01 13:54   ` Tobias Klauser
2010-10-01 13:22 ` [PATCH 7/8] altera_uart: Fix missing prototype for registering an early console Anton Vorontsov
2010-10-01 13:52   ` Tobias Klauser
2010-10-01 13:23 ` [PATCH 8/8] altera_uart: Don't use plain integer as NULL pointer Anton Vorontsov
2010-10-01 13:50   ` Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101001132133.GB25897@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox